[Bug 4013] Please add IP address host checking to urirhsbl and urirhssub

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=4013





------- Additional Comments From felicity@kluge.net  2004-12-03 07:17 -------
Cut/pasting my response to the mail thread about this since it explains what is currently happening:

The code does so explicitly, but since I didn't write the plugin so I
can't say why it does what it does:
  
  if ($dom =~ /^\d+\.\d+\.\d+\.\d+$/) {
    $self->lookup_dnsbl_for_ip ($scanstate, $obj, $dom);
  }
  else {
    # look up the domain in the RHSBL subset
[...]

uridnsbl flags rules as active_rules_revipbl, which lookup_dnsbl_for_ip
uses to know which rules to send IPs for.  revipbl rules also get domains
queried.

urirhs* are active_rules_rhsbl, which just get domains.

    if ($rulecf->{is_rhsbl}) {
      $scanstate->{active_rules_rhsbl}->{$rulename} = 1;
    } else {
      $scanstate->{active_rules_revipbl}->{$rulename} = 1;
    }

is the code in question.  I don't know why there's a difference.  Perhaps
instead of rule types specifying the difference it should be a tflag?  Assume
they all do both IP and domain unless "tflags nouriip" is set or something?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.