You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2017/07/05 11:23:46 UTC
Re: Struts 2.5.11 not serving iclass icons
This is very strange ... I don't understand where is the problem :\ Do
you serve those CSSs files via the Strust filter as a static content?
2017-06-26 12:04 GMT+02:00 info@flyingfischer.ch <in...@flyingfischer.ch>:
> Am 26.06.2017 um 11:55 schrieb Lukasz Lenart:
>> 2017-06-26 11:50 GMT+02:00 info@flyingfischer.ch <in...@flyingfischer.ch>:
>>> Yes, the import statement is already there. It is a combined css file
>>> (fonts and other CSS statements). Works perfect, also for 2.5.11. But
>>> the webfonts seem to be treated differently, but only if used as <i
>>> class="fa fa-envelope-o"></i>.
>>>
>>> I worked around for this single case.
>> You mean, you have resolved the problem by using UTF entity instead as
>> mentioned in some other mail?
>>
>>
>> Regards
> The following works:
>
> <i class="fa icon-envelope"></i>
> <i class="fa"></i>
>
> The following does not work since 2.5.11:
>
> <i class="fa fa-envelope-o"></i>
>
> They all refer to the same icon.
>
> They refer in CSS to:
>
> .icon-envelope:before {
> content: "\e086"; }
>
> .fa-envelope-o:before {
> content: ""; }
>
> The later is the text being displayed since the upgrade.
>
> Markus
>
> PS: Tomcat runs on URI-Encoding="UTF-8"
>
> JSP contain <meta charset="utf-8"> and <%@ page language="java"
> contentType="text/html; charset=utf-8" pageEncoding="utf-8"%>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.11 not serving iclass icons
Posted by Lukasz Lenart <lu...@apache.org>.
2017-07-06 9:18 GMT+02:00 info@flyingfischer.ch <in...@flyingfischer.ch>:
> Thanks again for insisting so much on looking into this. I think I got
> the (painful simple) root reason:
>
> While further debuggin on the empty locale story, I did reset to
> 2.5.10.1 and then back again 2.5.11 and I also did clean the Tomcat
> working directory...
>
> ...now setting up a test page like below, things work out! And helas,
> even in the original page all three versions work out.
>
> I am really sorry for this. Testing is hard and may lead to false
> negatives: got 2 wrong and 2 right. I need to improve. ;-/
Great! And don't worry, I'm so thankful that you have spent so much
time on testing the new release :) I prefer to postpone a new release
instead of introducing an inconsistency in minor versions ;-)
Best regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.11 not serving iclass icons
Posted by "info@flyingfischer.ch" <in...@flyingfischer.ch>.
Thanks again for insisting so much on looking into this. I think I got
the (painful simple) root reason:
While further debuggin on the empty locale story, I did reset to
2.5.10.1 and then back again 2.5.11 and I also did clean the Tomcat
working directory...
...now setting up a test page like below, things work out! And helas,
even in the original page all three versions work out.
I am really sorry for this. Testing is hard and may lead to false
negatives: got 2 wrong and 2 right. I need to improve. ;-/
Markus
Am 06.07.2017 um 08:16 schrieb Lukasz Lenart:
> Argh... forgot to add a CSS stylesheet and now everything works as
> expected, my setup below:
>
> <%@ page contentType="text/html; charset=UTF-8" %>
> <%@ taglib prefix="s" uri="/struts-tags" %>
> <html>
> <head>
> <title>Action Chaining</title>
> <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"
> rel="stylesheet" media="all">
> <link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css"
> rel="stylesheet"
> integrity="sha384-wvfXpqpZZVQGK6TAh5PVlGOfQNHSoD2xbE+QkPxCAFlNEevoEH3Sl0sibVcOQVnN"
> crossorigin="anonymous">
> <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"
> type="application/javascript"></script>
> </head>
>
> <body>
>
> <ul>
> <li>
> <i class="fa icon-envelope"></i> <!-- does not work -->
> </li>
> <li>
> <i class="fa"></i> <!-- works -->
> </li>
> <li>
> <i class="fa fa-envelope-o"></i> <!-- works -->
> </li>
> </ul>
>
> <s:a action="actionA">Action A</s:a>
>
> </body>
> </html>
>
> 2017-07-06 8:12 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
>> I was able confirm this somehow ... but I need your exact setup, what
>> version of Bootstrap do you use? Do you use FontAwesome directly?
>>
>> There is no issue when I used a pure reference to FontAwesome (with
>> their CDN) but it doesn't work when using Bootstrap one.
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> 2017-07-05 14:05 GMT+02:00 info@flyingfischer.ch <in...@flyingfischer.ch>:
>>> Am 05.07.2017 um 13:23 schrieb Lukasz Lenart:
>>>> This is very strange ... I don't understand where is the problem :\ Do
>>>> you serve those CSSs files via the Strust filter as a static content?
>>>>
>>> The CSS file seems to get through. The Layout is as should. The CSS file
>>> is packed in a subdirectory of WebContent.
>>>
>>> Nothing has been changed between 2.5.10.1 and 2.5.11. But do not mind
>>> too much, if I have two working options:
>>>
>>> The following works:
>>>
>>> <i class="fa icon-envelope"></i>
>>> <i class="fa"></i>
>>>
>>> The following does not work since 2.5.11:
>>>
>>> <i class="fa fa-envelope-o"></i>
>>>
>>> web.xml
>>>
>>> <listener>
>>>
>>> <listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
>>> </listener>
>>>
>>> <filter>
>>> <filter-name>struts2</filter-name>
>>>
>>> <filter-class>org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter</filter-class>
>>> </filter>
>>>
>>> <filter-mapping>
>>> <filter-name>struts2</filter-name>
>>> <url-pattern>/*</url-pattern>
>>> </filter-mapping>
>>>
>>> struts.xml
>>>
>>> <constant name="struts.action.extension" value=","/>
>>>
>>> Markus
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.11 not serving iclass icons
Posted by Lukasz Lenart <lu...@apache.org>.
Argh... forgot to add a CSS stylesheet and now everything works as
expected, my setup below:
<%@ page contentType="text/html; charset=UTF-8" %>
<%@ taglib prefix="s" uri="/struts-tags" %>
<html>
<head>
<title>Action Chaining</title>
<link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"
rel="stylesheet" media="all">
<link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css"
rel="stylesheet"
integrity="sha384-wvfXpqpZZVQGK6TAh5PVlGOfQNHSoD2xbE+QkPxCAFlNEevoEH3Sl0sibVcOQVnN"
crossorigin="anonymous">
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"
type="application/javascript"></script>
</head>
<body>
<ul>
<li>
<i class="fa icon-envelope"></i> <!-- does not work -->
</li>
<li>
<i class="fa"></i> <!-- works -->
</li>
<li>
<i class="fa fa-envelope-o"></i> <!-- works -->
</li>
</ul>
<s:a action="actionA">Action A</s:a>
</body>
</html>
2017-07-06 8:12 GMT+02:00 Lukasz Lenart <lu...@apache.org>:
> I was able confirm this somehow ... but I need your exact setup, what
> version of Bootstrap do you use? Do you use FontAwesome directly?
>
> There is no issue when I used a pure reference to FontAwesome (with
> their CDN) but it doesn't work when using Bootstrap one.
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> 2017-07-05 14:05 GMT+02:00 info@flyingfischer.ch <in...@flyingfischer.ch>:
>> Am 05.07.2017 um 13:23 schrieb Lukasz Lenart:
>>> This is very strange ... I don't understand where is the problem :\ Do
>>> you serve those CSSs files via the Strust filter as a static content?
>>>
>>
>> The CSS file seems to get through. The Layout is as should. The CSS file
>> is packed in a subdirectory of WebContent.
>>
>> Nothing has been changed between 2.5.10.1 and 2.5.11. But do not mind
>> too much, if I have two working options:
>>
>> The following works:
>>
>> <i class="fa icon-envelope"></i>
>> <i class="fa"></i>
>>
>> The following does not work since 2.5.11:
>>
>> <i class="fa fa-envelope-o"></i>
>>
>> web.xml
>>
>> <listener>
>>
>> <listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
>> </listener>
>>
>> <filter>
>> <filter-name>struts2</filter-name>
>>
>> <filter-class>org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter</filter-class>
>> </filter>
>>
>> <filter-mapping>
>> <filter-name>struts2</filter-name>
>> <url-pattern>/*</url-pattern>
>> </filter-mapping>
>>
>> struts.xml
>>
>> <constant name="struts.action.extension" value=","/>
>>
>> Markus
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.11 not serving iclass icons
Posted by Lukasz Lenart <lu...@apache.org>.
I was able confirm this somehow ... but I need your exact setup, what
version of Bootstrap do you use? Do you use FontAwesome directly?
There is no issue when I used a pure reference to FontAwesome (with
their CDN) but it doesn't work when using Bootstrap one.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
2017-07-05 14:05 GMT+02:00 info@flyingfischer.ch <in...@flyingfischer.ch>:
> Am 05.07.2017 um 13:23 schrieb Lukasz Lenart:
>> This is very strange ... I don't understand where is the problem :\ Do
>> you serve those CSSs files via the Strust filter as a static content?
>>
>
> The CSS file seems to get through. The Layout is as should. The CSS file
> is packed in a subdirectory of WebContent.
>
> Nothing has been changed between 2.5.10.1 and 2.5.11. But do not mind
> too much, if I have two working options:
>
> The following works:
>
> <i class="fa icon-envelope"></i>
> <i class="fa"></i>
>
> The following does not work since 2.5.11:
>
> <i class="fa fa-envelope-o"></i>
>
> web.xml
>
> <listener>
>
> <listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
> </listener>
>
> <filter>
> <filter-name>struts2</filter-name>
>
> <filter-class>org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter</filter-class>
> </filter>
>
> <filter-mapping>
> <filter-name>struts2</filter-name>
> <url-pattern>/*</url-pattern>
> </filter-mapping>
>
> struts.xml
>
> <constant name="struts.action.extension" value=","/>
>
> Markus
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Struts 2.5.11 not serving iclass icons
Posted by "info@flyingfischer.ch" <in...@flyingfischer.ch>.
Am 05.07.2017 um 13:23 schrieb Lukasz Lenart:
> This is very strange ... I don't understand where is the problem :\ Do
> you serve those CSSs files via the Strust filter as a static content?
>
The CSS file seems to get through. The Layout is as should. The CSS file
is packed in a subdirectory of WebContent.
Nothing has been changed between 2.5.10.1 and 2.5.11. But do not mind
too much, if I have two working options:
The following works:
<i class="fa icon-envelope"></i>
<i class="fa"></i>
The following does not work since 2.5.11:
<i class="fa fa-envelope-o"></i>
web.xml
<listener>
<listener-class>org.apache.struts2.tiles.StrutsTilesListener</listener-class>
</listener>
<filter>
<filter-name>struts2</filter-name>
<filter-class>org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter</filter-class>
</filter>
<filter-mapping>
<filter-name>struts2</filter-name>
<url-pattern>/*</url-pattern>
</filter-mapping>
struts.xml
<constant name="struts.action.extension" value=","/>
Markus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org