Re: [PR] H3: Make sure we remove streams when needed. [trafficserver]

["ywkaras (via GitHub)" <gi...@apache.org>]

ywkaras commented on code in PR #11490:
URL: https://github.com/apache/trafficserver/pull/11490#discussion_r1661105194


##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -645,8 +645,8 @@ QUICNetVConnection::_handle_read_ready()
     QUICConVDebug("stream %" PRIu64 " is readable\n", s);
     QUICStream *stream = static_cast<QUICStream *>(this->_stream_manager->find_stream(s));
     if (stream == nullptr) {
-      this->_stream_manager->create_stream(s);
-      stream = static_cast<QUICStream *>(this->_stream_manager->find_stream(s));
+      [[maybe_unused]] QUICConnectionError err;

Review Comment:
   Maybe you should check it with ink_assert for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org