You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bsf-dev@jakarta.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2008/05/21 19:05:55 UTC
[jira] Created: (BSF-17) Unnamed block in BSF_Log should be static?
Unnamed block in BSF_Log should be static?
------------------------------------------
Key: BSF-17
URL: https://issues.apache.org/jira/browse/BSF-17
Project: BSF
Issue Type: Bug
Reporter: Sebb
There is an unnamed block in BSF_Log (starting at line 70) which looks as though it ought to be a static block.
If not, it should be given a name and/or be commented.
If it is supposed to be a static block, then it would be sensible to make the static fields final as far as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
[jira] Commented: (BSF-17) Unnamed block in BSF_Log should be
static?
Posted by "Rony G. Flatscher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BSF-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598731#action_12598731 ]
Rony G. Flatscher commented on BSF-17:
--------------------------------------
+1
> Unnamed block in BSF_Log should be static?
> ------------------------------------------
>
> Key: BSF-17
> URL: https://issues.apache.org/jira/browse/BSF-17
> Project: BSF
> Issue Type: Bug
> Reporter: Sebb
>
> There is an unnamed block in BSF_Log (starting at line 70) which looks as though it ought to be a static block.
> If not, it should be given a name and/or be commented.
> If it is supposed to be a static block, then it would be sensible to make the static fields final as far as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org
[jira] Resolved: (BSF-17) Unnamed block in BSF_Log should be
static?
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BSF-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved BSF-17.
---------------------
Resolution: Fixed
Updated SVN trunk:
commit -m "BSF-17 - convert unnamed block to static initialiser; make all fields final so class is now immutable"
Committed revision 658912.
> Unnamed block in BSF_Log should be static?
> ------------------------------------------
>
> Key: BSF-17
> URL: https://issues.apache.org/jira/browse/BSF-17
> Project: BSF
> Issue Type: Bug
> Reporter: Sebb
>
> There is an unnamed block in BSF_Log (starting at line 70) which looks as though it ought to be a static block.
> If not, it should be given a name and/or be commented.
> If it is supposed to be a static block, then it would be sensible to make the static fields final as far as possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org