You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@age.apache.org by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org> on 2023/02/01 20:21:10 UTC

[GitHub] [age] MuhammadTahaNaveed opened a new pull request, #646: Fix WITH ignoring WHERE clause

MuhammadTahaNaveed opened a new pull request, #646:
URL: https://github.com/apache/age/pull/646

   - When transforming `cypher_with` into `cypher_return` clause, **where** node of `cypher_with` was lost since cypher_return has no where node and since the function transform_cypher_clause_with_where was only given the wrapper clause(which had transformed cypher_return from cypher_with) as parameter, the where node was lost.
   - Changed the function header of transform_cypher_clause_with_where to explicitly accept where node as parameter.
   - Added regression tests for cypher_with.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.

jrgemignani commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1424735929

   > > @MuhammadTahaNaveed Please review my comment above.
   > 
   > Hi john, Which one are you reffering to? I don't see any comment.
   
   Sorry, the pending review above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] MuhammadTahaNaveed commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.

MuhammadTahaNaveed commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1423363327

   ### Update
   
   Fix segmentation fault when referencing undefined variables in WITH clause.
   
   Now also Resolves
   - #329
   - #396 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] MuhammadTahaNaveed commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.

MuhammadTahaNaveed commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1439428752

   > @MuhammadTahaNaveed Is there a way to get this PR to run the new CI tests? It still lists Travis CI.
   
   Yes, sure.
   
   > @MuhammadTahaNaveed Is there a reason why you added an extra parameter to pass self->where instead of the way it was done?
   
   Yes. When `cypher_with` is converted into `cypher_return` in function `transform_cypher_with`, the where node of `cypher_with` gets lost because there is no node for where in `cypher_return` struct. 
   
   So, in order to transform the where node of `cypher_with`, we need to explicitly pass it to `transform_cypher_clause_with_where` because the self passed to it is cypher_return (that was converted from cypher_with).
   
   I hope this justifies the reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.

jrgemignani commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1439326638

   @MuhammadTahaNaveed Is there a reason why you added an extra parameter to pass self->where instead of the way it was done?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] MuhammadTahaNaveed commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.

MuhammadTahaNaveed commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1424699990

   > @MuhammadTahaNaveed Please review my comment above.
   
   Hi john,
   Which one are you reffering to? I don't see any comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani merged pull request #646: Fix WITH ignoring WHERE clause

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.

jrgemignani merged PR #646:
URL: https://github.com/apache/age/pull/646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.

jrgemignani commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1424689290

   @MuhammadTahaNaveed Please review my comment above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] jrgemignani commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.

jrgemignani commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1439322110

   @MuhammadTahaNaveed Is there a way to get this PR to run the new CI tests? It still lists Travis CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [age] dehowef commented on pull request #646: Fix WITH ignoring WHERE clause

Posted by "dehowef (via GitHub)" <gi...@apache.org>.

dehowef commented on PR #646:
URL: https://github.com/apache/age/pull/646#issuecomment-1441312078

   Looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org