You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/17 13:32:36 UTC
[GitHub] [incubator-pekko-connectors-kafka] pjfanning opened a new pull request, #15: add license and notice to jars
pjfanning opened a new pull request, #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15
* based on what is in incubator-pekko repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning merged pull request #15: add license and notice to jars
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #15: add license and notice to jars
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15#discussion_r1072217445
##########
LICENSE:
##########
@@ -1,16 +1,201 @@
-This software is licensed under the Apache 2 license, quoted below.
+ Apache License
+ Version 2.0, January 2004
+ https://www.apache.org/licenses/
Review Comment:
thanks - I copied the license from an out of date repo - fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #15: add license and notice to jars
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15#discussion_r1083995496
##########
NOTICE:
##########
@@ -0,0 +1,12 @@
+Apache Pekko Connectors Kafka
+Copyright 2022, 2023 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (https://www.apache.org/).
+
+This product contains significant parts that were originally based on software from Lightbend (Akka <https://akka.io/>).
+Copyright (C) 2014 - 2016 Softwaremill [http://softwaremill.com]
+Copyright (C) 2016 - 2022 Lightbend Inc. [http://www.lightbend.com]
+
+Apache Pekko is derived from Akka 2.6.x, the last version that was distributed under the
Review Comment:
thanks - I've fixed that now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] nvollmar commented on a diff in pull request #15: add license and notice to jars
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15#discussion_r1072216976
##########
NOTICE:
##########
@@ -0,0 +1,12 @@
+Apache Pekko Connectors Kafka
+Copyright 2022, 2023 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (https://www.apache.org/).
+
+This product contains significant parts that were originally based on software from Lightbend (Akka <https://akka.io/>).
+Copyright (C) 2014 - 2016 Softwaremill [http://softwaremill.com]
+Copyright (C) 2016 - 2022 Lightbend Inc. [http://www.lightbend.com]
+
+Apache Pekko is derived from Akka 2.6.x, the last version that was distributed under the
Review Comment:
Aache Pekko Connectors Kafka is derived from Alpakka Kafka 3.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] nvollmar commented on a diff in pull request #15: add license and notice to jars
Posted by GitBox <gi...@apache.org>.
nvollmar commented on code in PR #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15#discussion_r1072215493
##########
LICENSE:
##########
@@ -1,16 +1,201 @@
-This software is licensed under the Apache 2 license, quoted below.
+ Apache License
+ Version 2.0, January 2004
+ https://www.apache.org/licenses/
Review Comment:
should use http
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #15: add license and notice to jars
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #15:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/15#issuecomment-1400201718
@nvollmar would you be able to re-review if you time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org