[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #323: Fix #322 Make camel-attachments an optional dependency of platform-http

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #323: Fix #322 Make camel-attachments an optional dependency of platform-http
URL: https://github.com/apache/camel-quarkus/pull/323#discussion_r337944336
 
 

 ##########
 File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
 ##########
 @@ -272,4 +274,27 @@ void start(
             recorder.start(shutdown, main.getInstance());
         }
     }
+
+    /**
+     * Build steps related to Camel Attachments.
+     */
+    public static class Attachments {
+
+        /**
+         * Produces an {@link UploadAttacherBuildItem} holding a no-op {@link UploadAttacher}.
+         * <p>
+         * Note that this {@link BuildStep} is effective only if {@code camel-quarkus-attachments} extension is not in
+         * the class path.
+         *
+         * @param recorder the {@link CoreAttachmentsRecorder}
+         * @return a new {@link UploadAttacherBuildItem}
+         */
+        @Overridable
+        @Record(value = ExecutionTime.STATIC_INIT, optional = true)
+        @BuildStep(onlyIfNot = Flags.AttachmentsAvailable.class)
 
 Review comment:
   Don't think this flag is needed as the build item is marked as @Overridable, thus is is overridden by the build item from the attachment extension

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services