You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Oliver Rossmueller (JIRA)" <my...@incubator.apache.org> on 2005/08/30 00:41:06 UTC
[jira] Created: (MYFACES-458) javax.faces.component._ComponentAttributesMap implementation not correct
javax.faces.component._ComponentAttributesMap implementation not correct
------------------------------------------------------------------------
Key: MYFACES-458
URL: http://issues.apache.org/jira/browse/MYFACES-458
Project: MyFaces
Type: Bug
Components: Implementation
Reporter: Oliver Rossmueller
according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-458) javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
Martin Marinschek closed MYFACES-458:
-------------------------------------
Fix Version: Nightly Build
Resolution: Fixed
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: Nightly Build
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-458) javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
Martin Marinschek closed MYFACES-458:
-------------------------------------
Resolution: Fixed
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: Nightly Build
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "sean schofield (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
sean schofield reopened MYFACES-458:
------------------------------------
Fix caused massive TCK problems. We can revisit this once the 1.1.2 release is out the door.
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: 1.1.2-SNAPSHOT
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
Martin Marinschek reopened MYFACES-458:
---------------------------------------
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: 1.1.0
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "sean schofield (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=comments#action_12373744 ]
sean schofield commented on MYFACES-458:
----------------------------------------
TCK Compatability does in fact break because of this.
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: 1.1.2-SNAPSHOT
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-458) javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Oliver Rossmueller (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
Oliver Rossmueller updated MYFACES-458:
---------------------------------------
Component: JSR-127
(was: Implementation)
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Christophe Jolif (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=comments#action_12363969 ]
Christophe Jolif commented on MYFACES-458:
------------------------------------------
Hi Martin,
Indeed the javadoc says:
"Any attempt to add a null key or value must throw a NullPointerException."
But on the other hand:
1/ the JSF specification doesn't talk about that
2/ the javadoc of the put method also says: "If the property is not writeable, or an attempt is made to set a property of primitive type to null, throw IllegalArgumentException." which sounds to me as if it implies that null on non primitive types is accepted.
3/ the RI accepts null
4/ setters accept null
Thus, my understanding would be that you cannot add a new pair with null key (*add*, i.e. put without previous key), but you can put a previously set value back to null.
Did you check with the JSR if is it not a javadoc that is just unclear? Indeed we have code failing because of this "fix" in MyFaces.
Thanks.
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: 1.1.0
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=comments#action_12363985 ]
Adam Winer commented on MYFACES-458:
------------------------------------
The intent of the spec is certainly to allow putting null where there is a setter taking a non-primitive type. The Javadoc (which is, FWIW, actually considered part of the spec) should be clearer, and I'll file an issue on this.
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: 1.1.0
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (MYFACES-458) javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
Martin Marinschek reopened MYFACES-458:
---------------------------------------
some methods put values into the map which are null - so this problem is not solved so far.
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: Nightly Build
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=comments#action_12373769 ]
Martin Marinschek commented on MYFACES-458:
-------------------------------------------
Can someone bring this up to the RI team to get this test on the exclude list?
regards,
Martin
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: 1.1.2-SNAPSHOT
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf resolved MYFACES-458.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.1-SNAPSHOT
1.1.6-SNAPSHOT
see MYFACES-1681 (and a comment from Ryan, that the RI is doing it like we do it now)
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: https://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Matthias Weßendorf
> Priority: Critical
> Fix For: 1.1.6-SNAPSHOT, 1.2.1-SNAPSHOT
>
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-458) javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=comments#action_12320689 ]
Martin Marinschek commented on MYFACES-458:
-------------------------------------------
changed all occurences in the code where a null value might have been submitted
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: Nightly Build
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Christophe Jolif (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=comments#action_12374173 ]
Christophe Jolif commented on MYFACES-458:
------------------------------------------
As I said, this problem is compromising the ability of our JSF components to run on MyFaces, which means will have to tell people to stick to the RI if nothing is done. So I would like to know if progress has been made contacting TCK people to fix the test as apparently the spec intend was *not* to forbid null values on non-primitive types (see Adam Winer comment).
Thanks.
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Priority: Critical
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-458)
javax.faces.component._ComponentAttributesMap implementation not correct
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-458?page=all ]
Martin Marinschek closed MYFACES-458:
-------------------------------------
Fix Version: Nightly
(was: 1.1.0)
Resolution: Fixed
Well, I suppose Oliver changed this originally because there was a TCK-test failing due to this.
I committed a fix - if the TCK compatibility breaks due to this, we'll need a fix to the TCK-tests.
regards,
Martin
> javax.faces.component._ComponentAttributesMap implementation not correct
> ------------------------------------------------------------------------
>
> Key: MYFACES-458
> URL: http://issues.apache.org/jira/browse/MYFACES-458
> Project: MyFaces
> Type: Bug
> Components: JSR-127
> Reporter: Oliver Rossmueller
> Assignee: Martin Marinschek
> Fix For: Nightly
>
> according the UIComponent.getAttributes javadoc the Map implementation returned by this method for any attempt to add a null key or value must throw a NullPointerException
> The current implementation is correct for null keys but not does not check for null values.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira