You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by su...@apache.org on 2022/11/25 06:38:47 UTC

[shardingsphere] branch master updated: Remove useless getter of SQLCasesLoader (#22404)

This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ca7035bc3b Remove useless getter of SQLCasesLoader (#22404)
2ca7035bc3b is described below

commit 2ca7035bc3b2fe91a595724687b115b85ba72204
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Fri Nov 25 14:38:39 2022 +0800

    Remove useless getter of SQLCasesLoader (#22404)
---
 .../test/sql/parser/internal/loader/SQLCasesLoader.java           | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/loader/SQLCasesLoader.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/loader/SQLCasesLoader.java
index 85eb63bf6b4..a2da92f88bd 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/loader/SQLCasesLoader.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/loader/SQLCasesLoader.java
@@ -20,7 +20,6 @@ package org.apache.shardingsphere.test.sql.parser.internal.loader;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Splitter;
 import com.google.common.base.Strings;
-import lombok.Getter;
 import lombok.SneakyThrows;
 import org.apache.shardingsphere.sql.parser.sql.common.enums.ParameterMarkerType;
 import org.apache.shardingsphere.test.sql.parser.internal.cases.sql.domain.SQLCase;
@@ -46,7 +45,6 @@ import java.util.regex.Pattern;
 /**
  * SQL cases loader.
  */
-@Getter
 public final class SQLCasesLoader {
     
     private static final Pattern PARAMETER_MARKER = Pattern.compile("\\?|\\$[0-9]+");
@@ -101,9 +99,9 @@ public final class SQLCasesLoader {
     public String getCaseValue(final String sqlCaseId, final SQLCaseType sqlCaseType, final List<?> params) {
         switch (sqlCaseType) {
             case Literal:
-                return getLiteralSQL(getSQLFromMap(sqlCaseId, getCases()), params);
+                return getLiteralSQL(getSQLFromMap(sqlCaseId, cases), params);
             case Placeholder:
-                return getPlaceholderSQL(getSQLFromMap(sqlCaseId, getCases()));
+                return getPlaceholderSQL(getSQLFromMap(sqlCaseId, cases));
             default:
                 throw new UnsupportedOperationException(sqlCaseType.name());
         }
@@ -117,7 +115,7 @@ public final class SQLCasesLoader {
      */
     public Collection<Object[]> getTestParameters(final Collection<String> databaseTypes) {
         Collection<Object[]> result = new LinkedList<>();
-        for (SQLCase each : getCases().values()) {
+        for (SQLCase each : cases.values()) {
             result.addAll(getSQLTestParameters(databaseTypes, each));
         }
         return result;