You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Barry Kaplan (JIRA)" <ji...@apache.org> on 2009/11/12 20:11:52 UTC
[jira] Created: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Upgrade camel-scala to scala 2.8
--------------------------------
Key: CAMEL-2167
URL: https://issues.apache.org/activemq/browse/CAMEL-2167
Project: Apache Camel
Issue Type: Improvement
Components: camel-scala
Affects Versions: 2.0.0
Reporter: Barry Kaplan
Attachments: Upgrade_to_scala_2_8.patch
The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
Only a few changes were required:
- Change package declarations to new 2.8 style that allows relative imports
- Change org.apache.camel.scala.conveters.ScalaTypeConverter from a single object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56521#action_56521 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
Ok. I'm still dropping the compiler so there may be more java generics to fix.
But I'll try again with RC3 and see if fares any better.
I wish I could get a small test to crash the compiler so I could file a compiler issue. But with a
small test I get a reasonable error message. Only using the full camel-scala module do I
get a compiler crash.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2167) Upgrade camel-scala to
scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56076#action_56076 ]
Barry Kaplan edited comment on CAMEL-2167 at 11/24/09 7:09 PM:
---------------------------------------------------------------
Ah, well looks like its more java generics foo. Likely the self referentials, eg: "class ProcessorDefinition<Type extends org.apache.camel.model.ProcessorDefinition>".
This going to be a slog. Here is one example:
{code}
public abstract class OptionalIdentifiedDefinition<T extends OptionalIdentifiedDefinition> {..}
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition implements Block {..}
{code}
The above compiles fine with just javac. But when scalac see's this (when trying to compile scala) it complains that ProcessorDefinition does not provide the type argument for OptionalIdentifiedDefinition. I only found this by extracting out just the type declarations into a separate project. In that small project scalac did not crash but provided the error message. In the camel-scala project scalac just barfs.
_rant begin_ I hate java generics. I hate java. After a couple years of only scala, groovy, ruby, and c# I had forgotten what an archaic, noisy language java is. _rant end_
was (Author: memelet):
Ah, well looks like its more java generics foo. Likely the self referentials, eg: "class ProcessorDefinition<Type extends org.apache.camel.model.ProcessorDefinition>".
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barry Kaplan updated CAMEL-2167:
--------------------------------
Description:
The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
Only a few changes were required:
- Change package declarations to new 2.8 style that allows relative imports
- Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
was:
The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
Only a few changes were required:
- Change package declarations to new 2.8 style that allows relative imports
- Change org.apache.camel.scala.conveters.ScalaTypeConverter from a single object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56075#action_56075 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
Claus when you say "trunk now works again" do you mean with 2.7? I can crashing scalac beta1-rc1 with my patches applied.
And trying to figure out what the problem is quite hard since there are so many circular dependencies in camel-scala you can't compile one file a time.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2167) Upgrade camel-scala to
scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56075#action_56075 ]
Barry Kaplan edited comment on CAMEL-2167 at 11/24/09 7:41 PM:
---------------------------------------------------------------
Claus when you say "trunk now works again" do you mean with 2.7? I am crashing scalac beta1-rc1 with my patches applied.
And trying to figure out what the problem is quite hard since there are so many circular dependencies in camel-scala you can't compile one file a time.
was (Author: memelet):
Claus when you say "trunk now works again" do you mean with 2.7? I can crashing scalac beta1-rc1 with my patches applied.
And trying to figure out what the problem is quite hard since there are so many circular dependencies in camel-scala you can't compile one file a time.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55380#action_55380 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
Barry does camel-scala compile with success on your end with the latest code from trunk? i.e. using 2.8.
All the *cough* ugly jdk generics warnings removal (eclipse must be a bad editor since it shows all these warnings) have gotten the scala compiler to throw an internal error
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barry Kaplan updated CAMEL-2167:
--------------------------------
Description:
The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
Only a few changes were required:
- Change package declarations to new 2.8 style that allows relative imports
- Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
- Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
was:
The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
Only a few changes were required:
- Change package declarations to new 2.8 style that allows relative imports
- Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55382#action_55382 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
I have temporary disabled the camel-scala on trunk in rev: 835811.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55565#action_55565 ]
Hadrian Zbarcea commented on CAMEL-2167:
----------------------------------------
@Claus, I understand how you feel and I share some of it myself. I got complaints about the ridiculous number of compiler warnings in Camel. Sometimes they hide real issues (and I found that in a couple of cases). I agonized over the decision if to go for it or not. It is indicative though of some level of maturity, or at least it creates a perception of it and I leaned towards biting the bullet.
Sorry for breaking the scala component, my bad. I guess I owe you guys a beer. From the fact that you caught it so quickly it seems that you are following the cutting edge HEAD revision. Which probably means that... I owe you two beers :). Many thanks!
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55411#action_55411 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
Yes, trunk crashes the compiler for me as well. What was changed?
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reassigned CAMEL-2167:
--------------------------------------
Assignee: Hadrian Zbarcea
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55357#action_55357 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
2.8 is not byte code compatible with 2.7, so most likely there will be a need to support both version concurrently. I changed the pom to "camel-scala-2_8" to reflect this. But you might still want to wait until 2.8 is released as the compiler, language, and library is a daily moving target. In the meantime I will use the 2.8 version on my project.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2167) Upgrade camel-scala to
scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56078#action_56078 ]
Barry Kaplan edited comment on CAMEL-2167 at 11/24/09 7:50 PM:
---------------------------------------------------------------
I don't even know what makes sense for ProcessorDefinitionclass above. I've tried:
{code}
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<ProcessorDefinition> ...
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<OptionalIdentifiedDefinition> ...
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<Type> ...
{code}
All of which compile with javac but none of which type check with scalac.
was (Author: memelet):
I don't even know what makes sense for ProcessorDefinitionclass above. I've tried:
{code}
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<ProcessorDefinition> ...
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<OptionalIdentifiedDefinition> ...
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<Type> ...
{code}
All of which compile with javac but none of which type check with scalac.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2167:
-------------------------------
Fix Version/s: (was: 2.3.0)
2.4.0
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.4.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2167:
-------------------------------
Fix Version/s: (was: 2.2.0)
I will put that to 2.3 as Scala 2.8 must be GA first
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56079#action_56079 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
_rant start_
Barry I am totally with you on java generics. Its a pain in the b*** to use when its used for a little more than just avoiding ugly type cast.
And on other platforms AIX, HP-UX etc. code that compiles with SUN javac fails on these platforms. To bad they didnt implemented something that was easier and ligher. And got those closure in as well. As James Strachan says - javac is dying.
_rant end_
I have used scala 2.7.7 on trunk and I haven't seen any errors/warns. Do you see that on trunk? e.g without your patches etc.?
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2167) Upgrade camel-scala to
scala 2.8.0.RC6
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60213#action_60213 ]
Gert Vanthienen edited comment on CAMEL-2167 at 6/22/10 4:27 PM:
-----------------------------------------------------------------
Looks like the changes to the generics in the Java types together with the upgrade to the latest Scala 2.8.0.RC6 does work.
Fixed in http://svn.apache.org/viewvc?view=revision&revision=957013
Thanks to Hadrian and Barry for all the hard work in figuring these things out!
was (Author: gertvanthienen):
Looks like the changes to the generics in the Java types together with the upgrade to the latest Scala 2.8.0.RC6 does work.
Fixed in http://svn.apache.org/viewvc?view=revision&revision=957013
> Upgrade camel-scala to scala 2.8.0.RC6
> --------------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.4.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55563#action_55563 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
Great! I've been out for some days. I'll give it a go. Thanks!
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barry Kaplan updated CAMEL-2167:
--------------------------------
Attachment: Upgrade_to_scala_2_8.patch
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a single object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen resolved CAMEL-2167.
------------------------------------
Resolution: Fixed
Looks like the changes to the generics in the Java types together with the upgrade to the latest Scala 2.8.0.RC6 does work.
Fixed in http://svn.apache.org/viewvc?view=revision&revision=957013
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.4.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56174#action_56174 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
Trunk compiles fine with 2.7.x. Since I get compiler crashes when I try to compile the entire module,
probably there is a compiler bug lurking in there. I'll try to post the sample to the scala list and see if someone
can make sense of what types are required or whether one of the ones I tried should have worked.
In the meantime I'm gonna thunk down the java dsl so I can work with camel trunk.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2167:
-------------------------------
Fix Version/s: 2.3.0
2.2.0
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56078#action_56078 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
I don't even know what makes sense for ProcessorDefinitionclass above. I've tried:
{code}
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<ProcessorDefinition> ...
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<OptionalIdentifiedDefinition> ...
public abstract class ProcessorDefinition<Type extends ProcessorDefinition> extends OptionalIdentifiedDefinition<Type> ...
{code}
All of which compile with javac but none of which type check with scalac.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55349#action_55349 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
We have to wait to apply this one before 2.8 is GA as we dont want to have a situation where we cant release Camel 2.1
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55346#action_55346 ]
Hadrian Zbarcea commented on CAMEL-2167:
----------------------------------------
Thanks for pointing it out and especially for the patch!
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56217#action_56217 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
Barry I have committed a fix to trunk about that generics
trunk: 886072.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55492#action_55492 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
Barry trunk code now works with scala again
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2167) Upgrade camel-scala to scala 2.8.0.RC6
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated CAMEL-2167:
-----------------------------------
Summary: Upgrade camel-scala to scala 2.8.0.RC6 (was: Upgrade camel-scala to scala 2.8)
> Upgrade camel-scala to scala 2.8.0.RC6
> --------------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.4.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55417#action_55417 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
Its Hadrian's work on removing Eclipse warnings because it think that all code must be ugly Java 5 genericfied.
Sorry but I am not keen on this work, Hadrian.
Often makes code even harder to read and maintain because of using <> everywhere and ugly cast utils needed.
I guess it makes compilers go crazy :(
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2167) Upgrade camel-scala to
scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55411#action_55411 ]
Barry Kaplan edited comment on CAMEL-2167 at 11/13/09 11:05 AM:
----------------------------------------------------------------
Yes, trunk crashes the compiler for me as well. What was changed? Wait, Its using 2.7.3, can't figure out why (yet...)
was (Author: memelet):
Yes, trunk crashes the compiler for me as well. What was changed?
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56203#action_56203 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
I think I've made a breakthru. In my sandbox (where I've created skeletons of some of the camel-core and camel-scala classes) I have gotten past what was causing the compiler to crash in the full build and generate type errors in the sandbox.
(For this case at last) it was a mistake in the java generics:
{code}
public class ExpressionNode extends ProcessorDefinition<ProcessorDefinition> {..}
{code}
Should be:
{code}
public class ExpressionNode extends ProcessorDefinition<ExpressionNode > {..}
{code}
Which allowed this to type check:
{code}
abstract class SAbstractDefinition[P <: ProcessorDefinition[_]] {..}
case class SIdempotentConsumerDefinition(val target: IdempotentConsumerDefinition) extends SAbstractDefinition[IdempotentConsumerDefinition] {..}
{code}
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55418#action_55418 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
Barry have you tried trunk code with 2.8.0 Scala compiler?
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56076#action_56076 ]
Barry Kaplan commented on CAMEL-2167:
-------------------------------------
Ah, well looks like its more java generics foo. Likely the self referentials, eg: "class ProcessorDefinition<Type extends org.apache.camel.model.ProcessorDefinition>".
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2167) Upgrade camel-scala to scala 2.8
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56210#action_56210 ]
Claus Ibsen commented on CAMEL-2167:
------------------------------------
Barry well spotted, those Java generics is like have/love combo.
> Upgrade camel-scala to scala 2.8
> --------------------------------
>
> Key: CAMEL-2167
> URL: https://issues.apache.org/activemq/browse/CAMEL-2167
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-scala
> Affects Versions: 2.0.0
> Reporter: Barry Kaplan
> Assignee: Hadrian Zbarcea
> Fix For: 2.2.0, 2.3.0
>
> Attachments: Upgrade_to_scala_2_8.patch
>
>
> The attached patch upgrades to 2.8.0-SNAPSHOT (actually a specific version, but pretty close to today).
> Only a few changes were required:
> - Change package declarations to new 2.8 style that allows relative imports
> - Change org.apache.camel.scala.conveters.ScalaTypeConverter from a singleton object to a class. Otherwise ObjectHelper failed to instantiate the converter due to private access. (This could be 2.8 bug. I will need to raise an issue.)
> - Removed generic parameters on references to java classes that were not generic. Don't know why this compiled with scala 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.