[GitHub] [hudi] danny0405 commented on a change in pull request #4821: [HUDI-3435] Do not throw exception when instant to rollback does not …

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #4821:
URL: https://github.com/apache/hudi/pull/4821#discussion_r816396889



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java
##########
@@ -429,25 +428,21 @@ public void mergeArchiveFiles(List<FileStatus> compactCandidate) throws IOExcept
         .collect(Collectors.groupingBy(i -> Pair.of(i.getTimestamp(),
             HoodieInstant.getComparableAction(i.getAction()))));
 
-    // If metadata table is enabled, do not archive instants which are more recent than the last compaction on the
-    // metadata table.
-    if (config.isMetadataTableEnabled()) {
-      try (HoodieTableMetadata tableMetadata = HoodieTableMetadata.create(table.getContext(), config.getMetadataConfig(),
-          config.getBasePath(), FileSystemViewStorageConfig.SPILLABLE_DIR.defaultValue())) {
-        Option<String> latestCompactionTime = tableMetadata.getLatestCompactionTime();

Review comment:
       > There can be the case where deltacommit on the metadata table succeeds but commit on dataset fails (inflight -> complete transition fails).
   
   When the job restarts, the last commit would be rollbacked first right ? And the view of the metadata table would be fixed then, so this should not be a problem.
   
   In any case, the metadata table was read with latest filesystem view which includes the delta commits logs files, i don't  know why we address metadata compaction here because compaction does not affect the table records.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org