You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/10/02 14:46:21 UTC
[I] Reevaluate setgoal and getgoal shell command names [accumulo]
keith-turner opened a new issue, #3800:
URL: https://github.com/apache/accumulo/issues/3800
See this discussion :
https://github.com/apache/accumulo/pull/3785#discussion_r1339509741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745536399
> The was / is (?) a utility class `../manager/state/SetGoalState.java` - we may want to try and be consistent with naming - (assuming the utility is still needed.)
That class was specifically setting a manager goal state. I think it's related, but not quite the same as what these are doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "jmark99 (via GitHub)" <gi...@apache.org>.
jmark99 commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745213529
The downside of using something like `setgoalstate` is that is does not offer any more context than `setgoal`, which was the impetus for the initial issue to be opened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "jmark99 (via GitHub)" <gi...@apache.org>.
jmark99 closed issue #3800: Reevaluate setgoal and getgoal shell command names
URL: https://github.com/apache/accumulo/issues/3800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "jmark99 (via GitHub)" <gi...@apache.org>.
jmark99 commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745147345
@keith-turner, @ctubbsii I like the idea of `sethostinggoal` and `gethostinggoal`. If you prefer to be even more specific we could use `settablethostinggoal` and `gettablethostinggoal`. Those are a little longer, but no more than the existing shell command, `namespacepermissions`. If you are good going this route, let me know which one you prefer and I will make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745580505
@ctubbsii is correct. My fault - I confused the two commands and their intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745600467
> @keith-turner, @ctubbsii I like the idea of sethostinggoal and gethostinggoal.
@jmark99 I like sethostinggoal and gethostinggoal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745251224
If we go with `sethostinggoal` then we may want to consider renaming the SetGoalState class (or make an alias and keep both?) There are downsides to changing the class (esp. if referenced in the docs somewhere), but there may be a benefit if both methods (shell, utility) are similarly named so that it is clear that the are doing the same thing.
I am not advocating for one name or another, just wondering if we want to be consistent in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "jmark99 (via GitHub)" <gi...@apache.org>.
jmark99 commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1761434242
Closed by #3842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reevaluate setgoal and getgoal shell command names [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #3800:
URL: https://github.com/apache/accumulo/issues/3800#issuecomment-1745170514
The was / is (?) a utility class `../manager/state/SetGoalState.java` - we may want to try and be consistent with naming - (assuming the utility is still needed.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org