You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/05/06 18:24:00 UTC

[jira] [Commented] (PHOENIX-1949) NPE while inserting NULL in a VARCHAR array using UPSERT stmt

    [ https://issues.apache.org/jira/browse/PHOENIX-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530809#comment-14530809 ] 

Hadoop QA commented on PHOENIX-1949:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12730732/Phoenix-1949.patch
  against master branch at commit b47dcb66055642559b9dd75f5647473329df432f.
  ATTACHMENT ID: 12730732

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        conn.createStatement().execute("CREATE TABLE t ( k VARCHAR PRIMARY KEY, a VARCHAR ARRAY[])");
+                  value = arrayElemDataType.toObject(ptr, theArrayElemDataType, child.getSortOrder());
+                  value = arrayElemDataType.toObject(ptr, child.getDataType(), child.getSortOrder());

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.mapred.TestJobCounters.testHeapUsageCounter(TestJobCounters.java:692)

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/47//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/47//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/47//console

This message is automatically generated.

> NPE while inserting NULL in a VARCHAR array using UPSERT stmt
> -------------------------------------------------------------
>
>                 Key: PHOENIX-1949
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1949
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 4.4.0
>
>         Attachments: Phoenix-1949.patch
>
>
> With reference to the mail in user list there is an NPE when upserting NULL in an VARCHAR array as reported by Kathir
> {code}
> Is it possible to insert null elements in an array type column?
> CREATE TABLE ARRAYTEST124 (ID VARCHAR, NAME VARCHAR ARRAY CONSTRAINT PK PRIMARY KEY(ID))
> UPSERT INTO ARRAYTEST124 (ID, NAME) VALUES('123',ARRAY['ABC','XYZ',null])
> UPSERT INTO ARRAYTEST124 (ID, NAME) VALUES('123',ARRAY['ABC',null,'XYZ'])
> UPSERT INTO ARRAYTEST124 (ID, NAME) VALUES('123',ARRAY[null,'ABC','XYZ'])
> I'm using phoenix 4.4.0-HBase-0.98-rc0
> I'm getting a null pointer exception, while trying to do the above upserts
> java.lang.NullPointerException
>             at org.apache.phoenix.schema.types.PVarchar.toObject(PVarchar.java:62)
>             at org.apache.phoenix.schema.types.PDataType.toObject(PDataType.java:979)
>             at org.apache.phoenix.schema.types.PDataType.toObject(PDataType.java:992)
>             at org.apache.phoenix.compile.ExpressionCompiler.visitLeave(ExpressionCompiler.java:1275)
>             at org.apache.phoenix.compile.ExpressionCompiler.visitLeave(ExpressionCompiler.java:142)
>             at org.apache.phoenix.parse.ArrayConstructorNode.accept(ArrayConstructorNode.java:43)
>             at org.apache.phoenix.compile.UpsertCompiler.compile(UpsertCompiler.java:733)
>             at org.apache.phoenix.jdbc.PhoenixStatement$ExecutableUpsertStatement.compilePlan(PhoenixStatement.java:525)
>             at org.apache.phoenix.jdbc.PhoenixStatement$ExecutableUpsertStatement.compilePlan(PhoenixStatement.java:513)
>             at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:299)
>             at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:292)
>             at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
>             at org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:290)
>             at org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:222)
>             at org.apache.phoenix.jdbc.PhoenixPreparedStatement.execute(PhoenixPreparedStatement.java:173)
>             at org.apache.phoenix.jdbc.PhoenixPreparedStatement.execute(PhoenixPreparedStatement.java:178)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)