You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by s-urbaniak <gi...@git.apache.org> on 2016/01/22 14:58:42 UTC
[GitHub] spark pull request: Mesos: Configurable Mesos framework webui URL.
GitHub user s-urbaniak opened a pull request:
https://github.com/apache/spark/pull/10880
Mesos: Configurable Mesos framework webui URL.
Previously the Mesos framework webui URL was being derived only from the
Spark UI address leaving no possibility to configure it. This commit
makes it configurable. If unset i falls back to the previous behavior.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mesosphere/spark sur-webui-url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10880
----
commit af2f98c286918088cccca1a6932623559a5e7880
Author: Sergiusz Urbaniak <su...@mesosphere.io>
Date: 2016-01-22T13:57:19Z
Mesos: Configurable Mesos framework webui URL.
Previously the Mesos framework webui URL was being derived only from the
Spark UI address leaving no possibility to configure it. This commit
makes it configurable. If unset i falls back to the previous behavior.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Mesos: Configurable Mesos framework webui URL.
Posted by s-urbaniak <gi...@git.apache.org>.
Github user s-urbaniak commented on the pull request:
https://github.com/apache/spark/pull/10880#issuecomment-173949395
@srowen I apologize for the quick initiative then ;-) I'll peek through the contributing guidelines and close this PR then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Mesos: Configurable Mesos framework webui URL.
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10880#issuecomment-173942394
Please read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark first -- this isn't quite how we approach changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Mesos: Configurable Mesos framework webui URL.
Posted by sttts <gi...@git.apache.org>.
Github user sttts commented on the pull request:
https://github.com/apache/spark/pull/10880#issuecomment-173927801
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Mesos: Configurable Mesos framework webui URL.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10880#issuecomment-173928287
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Mesos: Configurable Mesos framework webui URL.
Posted by s-urbaniak <gi...@git.apache.org>.
Github user s-urbaniak closed the pull request at:
https://github.com/apache/spark/pull/10880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org