You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/04/13 11:55:11 UTC
[superset] branch master updated: chore: Enables GENERIC_CHART_AXES by default (#23652)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 0974fa1172 chore: Enables GENERIC_CHART_AXES by default (#23652)
0974fa1172 is described below
commit 0974fa1172564126c646c1e3d65e640a1b9bcbcd
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Thu Apr 13 08:55:01 2023 -0300
chore: Enables GENERIC_CHART_AXES by default (#23652)
---
RESOURCES/FEATURE_FLAGS.md | 2 +-
UPDATING.md | 1 +
.../cypress/integration/explore/visualizations/table.test.ts | 4 ++--
superset/config.py | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md
index 3374669870..13f4754f29 100644
--- a/RESOURCES/FEATURE_FLAGS.md
+++ b/RESOURCES/FEATURE_FLAGS.md
@@ -57,7 +57,6 @@ These features are **finished** but currently being tested. They are usable, but
- DASHBOARD_NATIVE_FILTERS
- DYNAMIC_PLUGINS: [(docs)](https://superset.apache.org/docs/installation/running-on-kubernetes)
- ENABLE_JAVASCRIPT_CONTROLS
-- GENERIC_CHART_AXES
- GLOBAL_ASYNC_QUERIES [(docs)](https://github.com/apache/superset/blob/master/CONTRIBUTING.md#async-chart-queries)
- RLS_IN_SQLLAB
- SSH_TUNNELING [(docs)](https://superset.apache.org/docs/installation/setup-ssh-tunneling)
@@ -98,3 +97,4 @@ These features flags currently default to True and **will be removed in a future
- ALLOW_DASHBOARD_DOMAIN_SHARDING
- DISPLAY_MARKDOWN_HTML
- FORCE_DATABASE_CONNECTIONS_SSL
+- GENERIC_CHART_AXES
diff --git a/UPDATING.md b/UPDATING.md
index 3496742bee..1a561aed40 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [23652](https://github.com/apache/superset/pull/23652) Enables GENERIC_CHART_AXES feature flag by default.
- [23226](https://github.com/apache/superset/pull/23226) Migrated endpoint `/estimate_query_cost/<int:database_id>` to `/api/v1/sqllab/estimate/`. Corresponding permissions are can estimate query cost on SQLLab. Make sure you add/replace the necessary permissions on any custom roles you may have.
- [22809](https://github.com/apache/superset/pull/22809): Migrated endpoint `/superset/sql_json` and `/superset/results/` to `/api/v1/sqllab/execute/` and `/api/v1/sqllab/results/` respectively. Corresponding permissions are `can sql_json on Superset` to `can execute on SQLLab`, `can results on Superset` to `can results on SQLLab`. Make sure you add/replace the necessary permissions on any custom roles you may have.
- [22931](https://github.com/apache/superset/pull/22931): Migrated endpoint `/superset/get_or_create_table/` to `/api/v1/dataset/get_or_create/`. Corresponding permissions are `can get or create table on Superset` to `can get or create dataset on Dataset`. Make sure you add/replace the necessary permissions on any custom roles you may have.
diff --git a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.ts b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.ts
index 46030bfb35..7db1dbe8ef 100644
--- a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.ts
+++ b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.ts
@@ -53,7 +53,7 @@ describe('Visualization > Table', () => {
granularity_sqla: undefined,
metrics: ['count'],
});
- cy.get('[data-test=granularity_sqla] .column-option-label').contains('ds');
+ cy.get('[data-test=adhoc_filters]').contains('ds');
});
it('Format non-numeric metrics correctly', () => {
@@ -126,7 +126,7 @@ describe('Visualization > Table', () => {
// should handle frontend sorting correctly
cy.get('.chart-container th').contains('name').click();
cy.get('.chart-container td:nth-child(2):eq(0)').contains('Adam');
- cy.get('.chart-container th').contains('Time').click().click();
+ cy.get('.chart-container th').contains('ds').click().click();
cy.get('.chart-container td:nth-child(1):eq(0)').contains('2008');
});
diff --git a/superset/config.py b/superset/config.py
index e26baa9a4e..f67b2f8b81 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -460,7 +460,7 @@ DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
# This could cause the server to run out of memory or compute.
"ALLOW_FULL_CSV_EXPORT": False,
"UX_BETA": False,
- "GENERIC_CHART_AXES": False,
+ "GENERIC_CHART_AXES": True,
"ALLOW_ADHOC_SUBQUERY": False,
"USE_ANALAGOUS_COLORS": False,
"DASHBOARD_EDIT_CHART_IN_NEW_TAB": False,