You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/29 16:19:49 UTC
[GitHub] [solr] cpoerschke opened a new pull request #772: SOLR-16104: TestCoreDiscovery.testTooManyTransientCores() to report loaded core names on failure
cpoerschke opened a new pull request #772:
URL: https://github.com/apache/solr/pull/772
https://issues.apache.org/jira/browse/SOLR-16104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #772: SOLR-16104: TestCoreDiscovery.testTooManyTransientCores() to report loaded core names on failure
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #772:
URL: https://github.com/apache/solr/pull/772#discussion_r837749426
##########
File path: solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java
##########
@@ -328,7 +328,7 @@ public void testTooManyTransientCores() throws Exception {
// Just check that the proper number of cores are loaded since making the test depend on order
// would be fragile
assertEquals(
- "There should only be 3 cores loaded, coreLOS and two coreT? cores",
+ "There should only be 3 cores loaded, coreLOS and two coreT? cores. Actual: "+cc.getLoadedCoreNames(),
Review comment:
The code at https://github.com/apache/solr/blob/0c73f3e64f46e8ae1134f2f19f8f0ad29990c9e5/solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java#L94 suggests that 3 as an absolute limit here is tricky.
Could the test perhaps poll and accept "3 or 4 but eventually 3" values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org