[jira] [Updated] (STORM-1599) Don't mark dependencies as provided unless they are in lib

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated STORM-1599:
---------------------------------------
    Summary: Don't mark dependencies as provided unless they are in lib  (was: Kafka dependencies all marked as provided (so storm-starter does not run))

> Don't mark dependencies as provided unless they are in lib
> ----------------------------------------------------------
>
>                 Key: STORM-1599
>                 URL: https://issues.apache.org/jira/browse/STORM-1599
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: examples, Flux, storm-kafka
>    Affects Versions: 0.10.0, 1.0.0, 2.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Hugo Louro
>
> When we mark a dependency as provided it indicates the shade and assembly plugins to not include this particular dependency in the uber topology jar because it will be {provided} on the class path by the system.
> We have been doing this for all of our kafka dependencies incorrectly.  This means that storm-starter does not have any version of kafka packaged it the resulting jar and any example that uses kafka, TridentKafkaWordCount, will fail with missing class errors. 
> storm-starter/pom.xml has should change its dependency on storm-kafka to be compile, and it should delete dependencies on kafka and kafka-clients as those should come from storm-kafka as transitive dependencies.
> the main pom.xml should not have kafka-clients marked as provided in the dependency management section.
> storm-kafka should remove its provided tag on kafka, and flux examples + storm-sql-kafka should remove dependencies on kafka and kafka-clients, and storm-kafka should not me marked as provided. 
> the flux and sql code I am not as familiar with, but looking at them, and running `mvn dependecy:tree` and `mvn dependency:analyze` it looks like



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)