You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/10 23:33:14 UTC

[GitHub] [kafka] lbradstreet commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

lbradstreet commented on a change in pull request #9729:
URL: https://github.com/apache/kafka/pull/9729#discussion_r540578510



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -1355,7 +1362,7 @@ public void run() {
                         } else if (heartbeat.sessionTimeoutExpired(now)) {
                             // the session timeout has expired without seeing a successful heartbeat, so we should
                             // probably make sure the coordinator is still healthy.
-                            markCoordinatorUnknown();
+                            markCoordinatorUnknown("session timed out without heartbeat");

Review comment:
       These messages feel a bit smelly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org