[jira] [Commented] (SCB-481) Fix qps handler assertion errors when schemaid or microservice name contails . (dot)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435504#comment-16435504 ] 

ASF GitHub Bot commented on SCB-481:
------------------------------------

liubao68 opened a new pull request #647: [SCB-481]Fix qps handler compatible issues due to assumption to schema ids not contains dot
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/647
 
 
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix qps handler assertion errors when schemaid or microservice name contails . (dot)
> ------------------------------------------------------------------------------------
>
>                 Key: SCB-481
>                 URL: https://issues.apache.org/jira/browse/SCB-481
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>            Reporter: liubao
>            Priority: Major
>
> As now we have default schema ids generate by @RpcContext and other. Qps handler assumes and assert schema id do not have . (dot) will cause compatible issues. Now we need to make it work. 
>  
> If we need have conventions for name, leave it to future discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)