You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/03/12 16:46:47 UTC
[GitHub] [nifi-registry] kevdoran commented on a change in pull request
#161: NIFIREG-234: Publish events for tenant CRUD
kevdoran commented on a change in pull request #161: NIFIREG-234: Publish events for tenant CRUD
URL: https://github.com/apache/nifi-registry/pull/161#discussion_r264774557
##########
File path: nifi-registry-core/nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/hook/EventFieldName.java
##########
@@ -26,6 +26,6 @@
EXTENSION_BUNDLE_ID,
VERSION,
USER,
- COMMENT;
-
+ USER_GROUP,
+ COMMENT
Review comment:
I'n not sure we should reuse the EventFieldName.USER for the the user that was created. In other contexts it indicates the user that performed the operation (speaking of which, maybe we want that information for tenant CRUD events?)
I would suggest adding new EventFieldNames that align with the the tenant data model, such as `TENANT_ID` and `TENANT_IDENTITY` that can be used for all tenant types, or if we want to break it down into users and groups, `USER_ID`, `USER_IDENTITY`, `USER_GROUP_ID`, `USER_GROUP_IDENTITY`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services