[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #5266: idle: remove heap & stack check in idle thread

[GitBox <gi...@apache.org>]

GUIDINGLI commented on pull request #5266:
URL: https://github.com/apache/incubator-nuttx/pull/5266#issuecomment-1016280233


   > @GUIDINGLI why were these removed?
   > 
   > We had to do some refactoring to `mm_trylock` to accommodate using `mm_checkcurrption` from the idle thread. If there is a reason to remove this, we are going to have to restore the old behaviour for `mm_trylock` as well.
   
   @Ouss4 You can see https://github.com/apache/incubator-nuttx/commit/9a53601ba993d43684328dcae8750acb00a34cc7, that's why removed.
   
   @fjpanag Actually, there is another way to resolve the issue caused by idle hold sem.
   
   We can do:
   enter_crtitical_sectiion();
   mm_checkcurrption();
   leave_crtitical_sectiion();
   
   Thus, there is no way to switch out during mm_checkcurrption(), and the issue will not happen.
   How do you think ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org