You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/05/28 23:32:35 UTC

[GitHub] [libcloud] michaelperel commented on a change in pull request #1278: [LIBCLOUD-1037] Add Azurite support for Azure Blob Storage driver

michaelperel commented on a change in pull request #1278: [LIBCLOUD-1037] Add Azurite support for Azure Blob Storage driver
URL: https://github.com/apache/libcloud/pull/1278#discussion_r288337598
 
 

 ##########
 File path: libcloud/storage/drivers/azure_blobs.py
 ##########
 @@ -214,8 +237,9 @@ def _xml_to_container(self, node):
             'meta_data': {}
         }
 
-        for meta in list(metadata):
-            extra['meta_data'][meta.tag] = meta.text
+        if metadata:
+            for meta in list(metadata):
+                extra['meta_data'][meta.tag] = meta.text
 
 Review comment:
   is meta.tag guaranteed to be not None?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services