You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ahmed Hussein (Jira)" <ji...@apache.org> on 2021/02/04 00:09:00 UTC
[jira] [Commented] (HADOOP-17513) Checkstyle IllegalImport does not
catch guava imports
[ https://issues.apache.org/jira/browse/HADOOP-17513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278433#comment-17278433 ]
Ahmed Hussein commented on HADOOP-17513:
----------------------------------------
Hey [~aajisaka], I think the checkstyle regex was not working correctly. Hopefully, in the future, this PR would help prevent avoiding guava imports before merging.
> Checkstyle IllegalImport does not catch guava imports
> -----------------------------------------------------
>
> Key: HADOOP-17513
> URL: https://issues.apache.org/jira/browse/HADOOP-17513
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Although YARN-10352 introduces {{guava iterator import}}, it was committed to trunk without checkstyle errors.
> According to [IllegalImportCheck#setIllegalPkgs |https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheck.java], the packages regex should be the prefix of the package. The code automatically append {{\.*}} to the regex.
> CC: [~aajisaka]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org