[GitHub] [jena] rvesse commented on a change in pull request #1134: JENA-2221: Remove Apache HTTP Client usage

[GitBox <gi...@apache.org>]

rvesse commented on a change in pull request #1134:
URL: https://github.com/apache/jena/pull/1134#discussion_r770375666



##########
File path: jena-arq/src/main/java/org/apache/jena/sparql/exec/http/Service.java
##########
@@ -188,7 +188,7 @@ private static HttpClient chooseHttpClient(String serviceURL, Context context) {
             Object client = context.get(httpQueryClient);
             if ( client != null ) {
                 // Check for old HttpClient
-                if ( client instanceof org.apache.http.client.HttpClient ) {
+                if ( client.getClass().getName().equals("org.apache.http.client.HttpClient") ) {
                     LOGGER.warn("Found Apache HttpClient for content symbol "+httpQueryClient+". Jena now uses java.net.http.HttpClient");

Review comment:
       Typo `content` -> `context`

##########
File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/ctl/Async.java
##########
@@ -18,13 +18,13 @@
 
 package org.apache.jena.fuseki.ctl;
 
-import org.apache.http.HttpHeaders;
 import org.apache.jena.atlas.json.JsonBuilder;
 import org.apache.jena.atlas.json.JsonValue;
 import org.apache.jena.fuseki.async.AsyncPool;
 import org.apache.jena.fuseki.async.AsyncTask;
 import org.apache.jena.fuseki.server.DataService;
 import org.apache.jena.fuseki.servlets.HttpAction;
+import org.apache.jena.riot.web.HttpNames;

Review comment:
       Does `java.net.http` not have an equivalent set of constants to Apache HTTP Client?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org