You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/28 21:45:09 UTC

[kudu-CR] KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement 

Hello Dan Burkert, Matthew Jacobs,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5249

to review the following change.

Change subject: KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement
......................................................................

KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement

As of IMPALA-3719, the CREATE EXTERNAL TABLE statement in Impala is
substantially simpler. Impala now reads the schema information from
Kudu, so we just need to specify the table name and master addresses,
and no longer need to list the columns.

Change-Id: I0fa2e7738a2f0a8f4eefeffed189a0330b41fe1f
---
M src/kudu/server/webui_util.cc
1 file changed, 2 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/5249/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fa2e7738a2f0a8f4eefeffed189a0330b41fe1f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>

[kudu-CR] KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement
......................................................................


KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement

As of IMPALA-3719, the CREATE EXTERNAL TABLE statement in Impala is
substantially simpler. Impala now reads the schema information from
Kudu, so we just need to specify the table name and master addresses,
and no longer need to list the columns.

Change-Id: I0fa2e7738a2f0a8f4eefeffed189a0330b41fe1f
Reviewed-on: http://gerrit.cloudera.org:8080/5249
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/server/webui_util.cc
1 file changed, 2 insertions(+), 62 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fa2e7738a2f0a8f4eefeffed189a0330b41fe1f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: KUDU-1763. Fix Impala CREATE EXTERNAL TABLE statement
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5249
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fa2e7738a2f0a8f4eefeffed189a0330b41fe1f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No