You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/04/23 01:59:42 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9064: stm32_eth: Lock the scheduler when reseting the MAC.

xiaoxiang781216 commented on code in PR #9064:
URL: https://github.com/apache/nuttx/pull/9064#discussion_r1174492280


##########
arch/arm/src/stm32/stm32_eth.c:
##########
@@ -2043,6 +2043,12 @@ static void stm32_interrupt_work(void *arg)
 
       stm32_putreg(ETH_DMAINT_AIS, STM32_ETH_DMASR);
 
+      /* Lock the scheduler, to ensure that the network
+       * will be unlocked before the worker starts.
+       */
+
+      sched_lock();

Review Comment:
   net_lock already do the sync between threads, why need add sched lock?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org