[GitHub] [hive] ganeshashree commented on a diff in pull request #4565: HIVE-27582: Do not cache HBase table input format in FetchOperator

["ganeshashree (via GitHub)" <gi...@apache.org>]

ganeshashree commented on code in PR #4565:
URL: https://github.com/apache/hive/pull/4565#discussion_r1288307735


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java:
##########
@@ -227,7 +227,11 @@ public static InputFormat getInputFormatFromCache(
     if (format == null) {
       try {
         format = ReflectionUtil.newInstance(inputFormatClass, conf);
-        inputFormats.put(inputFormatClass.getName(), format);
+        // HBase input formats are not thread safe today. See HIVE-8808.
+        String inputFormatName = inputFormatClass.getName().toLowerCase();
+        if (!inputFormatName.contains("hbase")) {

Review Comment:
   Yes, those input formats can also have the same issue if those are stateful or not thread safe. Depends on their implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org