You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2015/04/15 00:16:49 UTC
Review Request 33195: CMake Install DESTINATION lines all need added
COMPONENT spec; change qpid broker to separate install target
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33195/
-----------------------------------------------------------
Review request for qpid and Andrew Stitcher.
Bugs: QPID-6493
https://issues.apache.org/jira/browse/QPID-6493
Repository: qpid
Description
-------
Patch from Scott Stark created after he tried to build/install just qpidmessaging.
The patch files in the Jira are -R and hard to read. This review provides a better presentation of the diff.
Diffs
-----
trunk/qpid/cpp/BuildInstallSettings.cmake 1673556
trunk/qpid/cpp/src/CMakeLists.txt 1673556
Diff: https://reviews.apache.org/r/33195/diff/
Testing
-------
Installs just qpidmessaging when requested.
Thanks,
Chug Rolke
Re: Review Request 33195: CMake Install DESTINATION lines all need
added COMPONENT spec; change qpid broker to separate install target
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33195/#review80146
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Stitcher
On April 14, 2015, 10:16 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33195/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 10:16 p.m.)
>
>
> Review request for qpid and Andrew Stitcher.
>
>
> Bugs: QPID-6493
> https://issues.apache.org/jira/browse/QPID-6493
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Patch from Scott Stark created after he tried to build/install just qpidmessaging.
>
> The patch files in the Jira are -R and hard to read. This review provides a better presentation of the diff.
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/BuildInstallSettings.cmake 1673556
> trunk/qpid/cpp/src/CMakeLists.txt 1673556
>
> Diff: https://reviews.apache.org/r/33195/diff/
>
>
> Testing
> -------
>
> Installs just qpidmessaging when requested.
>
>
> Thanks,
>
> Chug Rolke
>
>