[GitHub] [beam] damccorm commented on a diff in pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #23109:
URL: https://github.com/apache/beam/pull/23109#discussion_r969880305


##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:

Review Comment:
   It would be nice to have some optional inputs like:
   
   ```
   inputs:
     requires-py-37:
       required: false
       default: 'true'
     requires-py-38:
       required: false
       default: 'true'
     requires-py-39:
       required: false
       default: 'true'
     requires-java-8:
       required: false
       default: 'true'
     requires-go-16:
       required: false
       default: 'true'
   ```
   
   So that a given job can specify if it doesn't need some set of dependencies. I agree installing all of them by default is a good idea though.



##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
+  using: "composite"
+  steps:
+    - name: Install python 3.7
+      uses: actions/setup-python@v4
+      with:
+        python-version: "3.7"
+    - name: Install python 3.8
+      uses: actions/setup-python@v4
+      with:
+        python-version: "3.8"
+    - name: Install python 3.9
+      uses: actions/setup-python@v4
+      with:
+        python-version: "3.9"
+    - name: Set Java Version
+      uses: actions/setup-java@v3
+      with:
+        distribution: 'temurin'
+        java-version: 8
+    - name: Set Go Version
+      uses: actions/setup-go@v3
+      with:
+        go-version: '>=1.16.0'

Review Comment:
   This version is probably not right. Go SDK tests require >=1.18, and playground tests require 1.16.
   
   I would recommend installing both separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org