You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/28 10:17:43 UTC
[GitHub] [submarine] ByronHsu opened a new pull request #613: SUBMARINE-857. Image should be built locally in github-action
ByronHsu opened a new pull request #613:
URL: https://github.com/apache/submarine/pull/613
### What is this PR for?
The current image is pulled from docker hub so the change in images will not be reflected immediately.
I revised the workflow files and build the images before deploying the cluster.
Also, I used Github action cache to cache docker layer to accelerate.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-867
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] ByronHsu commented on pull request #613: SUBMARINE-857. Image should be built locally in github-action
Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #613:
URL: https://github.com/apache/submarine/pull/613#issuecomment-869738038
@jeff-901 Help me review the code. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] ByronHsu commented on pull request #613: SUBMARINE-857. Image should be built locally in github-action
Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #613:
URL: https://github.com/apache/submarine/pull/613#issuecomment-869738038
@jeff-901 Help me review the code. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #613: SUBMARINE-857. Image should be built locally in github-action
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #613:
URL: https://github.com/apache/submarine/pull/613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on pull request #613: SUBMARINE-857. Image should be built locally in github-action
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on pull request #613:
URL: https://github.com/apache/submarine/pull/613#issuecomment-870245548
> @jeff-901 Help me review the code. Thanks!
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on pull request #613: SUBMARINE-857. Image should be built locally in github-action
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on pull request #613:
URL: https://github.com/apache/submarine/pull/613#issuecomment-870245548
> @jeff-901 Help me review the code. Thanks!
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #613: SUBMARINE-857. Image should be built locally in github-action
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #613:
URL: https://github.com/apache/submarine/pull/613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org