You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by cz...@apache.org on 2017/04/27 08:26:45 UTC
svn commit: r1792850 - in /sling/trunk/bundles/extensions/healthcheck/api:
./ src/main/java/org/apache/sling/hc/api/
src/main/java/org/apache/sling/hc/api/execution/
src/main/java/org/apache/sling/hc/util/
Author: cziegeler
Date: Thu Apr 27 08:26:45 2017
New Revision: 1792850
URL: http://svn.apache.org/viewvc?rev=1792850&view=rev
Log:
Use parent pom 30, OSGi annotations, clean up
Modified:
sling/trunk/bundles/extensions/healthcheck/api/pom.xml
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/HealthCheck.java
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutionResult.java
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutor.java
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/package-info.java
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/package-info.java
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/HealthCheckMetadata.java
sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/package-info.java
Modified: sling/trunk/bundles/extensions/healthcheck/api/pom.xml
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/pom.xml?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/pom.xml (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/pom.xml Thu Apr 27 08:26:45 2017
@@ -21,9 +21,10 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
- <artifactId>org.apache.sling.hc.reactor</artifactId>
<groupId>org.apache.sling</groupId>
- <version>1.0.3-SNAPSHOT</version>
+ <artifactId>sling</artifactId>
+ <version>30</version>
+ <relativePath />
</parent>
<modelVersion>4.0.0</modelVersion>
@@ -58,24 +59,11 @@
<dependencies>
<dependency>
<groupId>org.osgi</groupId>
- <artifactId>org.osgi.core</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.sling</groupId>
- <artifactId>org.apache.sling.commons.osgi</artifactId>
- <version>2.2.0</version>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>commons-lang</groupId>
- <artifactId>commons-lang</artifactId>
- <version>2.5</version>
- <scope>provided</scope>
+ <artifactId>osgi.core</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <version>1.6.2</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/HealthCheck.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/HealthCheck.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/HealthCheck.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/HealthCheck.java Thu Apr 27 08:26:45 2017
@@ -17,8 +17,7 @@
*/
package org.apache.sling.hc.api;
-import aQute.bnd.annotation.ConsumerType;
-
+import org.osgi.annotation.versioning.ConsumerType;
/**
* Health Check services can be executed and
@@ -60,7 +59,7 @@ public interface HealthCheck {
* The value of this property must be of type String or String array.
*/
String TAGS = "hc.tags";
-
+
/**
* Optional service property: If this property is set the health check
* will be executed asynchronously using the cron expression provided.
@@ -69,7 +68,7 @@ public interface HealthCheck {
/**
* Optional service property: TTL for health check {@link Result}.
- * The value of this property must be of type {@link Long} and is
+ * The value of this property must be of type {@link Long} and is
* specified in ms.
*/
String RESULT_CACHE_TTL_IN_MS = "hc.resultCacheTtlInMs";
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutionResult.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutionResult.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutionResult.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutionResult.java Thu Apr 27 08:26:45 2017
@@ -21,8 +21,8 @@ import java.util.Date;
import org.apache.sling.hc.api.Result;
import org.apache.sling.hc.util.HealthCheckMetadata;
+import org.osgi.annotation.versioning.ProviderType;
-import aQute.bnd.annotation.ProviderType;
/**
* Interface for health check executions via the {@link HealthCheckExecutor}.
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutor.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutor.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutor.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/HealthCheckExecutor.java Thu Apr 27 08:26:45 2017
@@ -20,8 +20,8 @@ package org.apache.sling.hc.api.executio
import java.util.List;
import org.apache.sling.hc.api.HealthCheck;
+import org.osgi.annotation.versioning.ProviderType;
-import aQute.bnd.annotation.ProviderType;
/**
* Executes health checks registered as OSGi services and
@@ -42,7 +42,7 @@ public interface HealthCheckExecutor {
/**
* Executes all health checks with the supplied list of tags.
* If no tags are supplied, all health checks are executed.
- *
+ *
* @param options options for controlling execution behavior
* @param tags tags to be executed
*
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/package-info.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/package-info.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/package-info.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/execution/package-info.java Thu Apr 27 08:26:45 2017
@@ -20,5 +20,4 @@
@Version("1.1.0")
package org.apache.sling.hc.api.execution;
-import aQute.bnd.annotation.Version;
-
+import org.osgi.annotation.versioning.Version;
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/package-info.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/package-info.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/package-info.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/api/package-info.java Thu Apr 27 08:26:45 2017
@@ -20,5 +20,4 @@
@Version("1.1.0")
package org.apache.sling.hc.api;
-import aQute.bnd.annotation.Version;
-
+import org.osgi.annotation.versioning.Version;
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/HealthCheckMetadata.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/HealthCheckMetadata.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/HealthCheckMetadata.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/HealthCheckMetadata.java Thu Apr 27 08:26:45 2017
@@ -21,8 +21,6 @@ import java.util.Arrays;
import java.util.LinkedList;
import java.util.List;
-import org.apache.commons.lang.StringUtils;
-import org.apache.sling.commons.osgi.PropertiesUtil;
import org.apache.sling.hc.api.HealthCheck;
import org.osgi.framework.Constants;
import org.osgi.framework.ServiceReference;
@@ -120,8 +118,8 @@ public class HealthCheckMetadata {
}
/**
- * TTL for the result cache in ms.
- *
+ * TTL for the result cache in ms.
+ *
* @return TTL for the result cache or <code>null</code> if not configured.
*/
public Long getResultCacheTtlInMs() {
@@ -152,13 +150,22 @@ public class HealthCheckMetadata {
private String getHealthCheckTitle(final ServiceReference ref) {
String name = (String) ref.getProperty(HealthCheck.NAME);
- if (StringUtils.isBlank(name)) {
- name = PropertiesUtil.toString(ref.getProperty(Constants.SERVICE_DESCRIPTION), null);
+ if (name == null || name.isEmpty()) {
+ final Object val = ref.getProperty(Constants.SERVICE_DESCRIPTION);
+ if ( val != null ) {
+ name = val.toString();
+ }
}
- if (StringUtils.isBlank(name)) {
+ if (name == null || name.isEmpty()) {
name = "HealthCheck:" + ref.getProperty(Constants.SERVICE_ID);
- final String pid = PropertiesUtil.toString(ref.getProperty(Constants.SERVICE_PID), null);
- if ( !StringUtils.isBlank(pid) ) {
+ final Object val = ref.getProperty(Constants.SERVICE_PID);
+ String pid = null;
+ if ( val instanceof String ) {
+ pid = (String)val;
+ } else if ( val instanceof String[]) {
+ pid = Arrays.toString((String[])val);
+ }
+ if ( pid != null && !pid.isEmpty() ) {
name = name + " (" + pid + ")";
}
}
@@ -166,7 +173,7 @@ public class HealthCheckMetadata {
}
private List<String> arrayPropertyToListOfStr(final Object arrayProp) {
- List<String> res = new LinkedList<String>();
+ List<String> res = new LinkedList<>();
if (arrayProp instanceof String) {
res.add((String) arrayProp);
} else if (arrayProp instanceof String[]) {
Modified: sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/package-info.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/package-info.java?rev=1792850&r1=1792849&r2=1792850&view=diff
==============================================================================
--- sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/package-info.java (original)
+++ sling/trunk/bundles/extensions/healthcheck/api/src/main/java/org/apache/sling/hc/util/package-info.java Thu Apr 27 08:26:45 2017
@@ -20,5 +20,4 @@
@Version("1.3.0")
package org.apache.sling.hc.util;
-import aQute.bnd.annotation.Version;
-
+import org.osgi.annotation.versioning.Version;