You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/19 14:17:20 UTC
[GitHub] [nifi] joewitt commented on pull request #5539: Nifi 8703
joewitt commented on pull request #5539:
URL: https://github.com/apache/nifi/pull/5539#issuecomment-974110520
Hello
Thanks for your contribution. On the initial commit for a PR you want to have a single commit rather than the full history it took to get here. This commit also reflects that there are rebase issues that will need to be resolved.
Also for such a processor you will want to ensure the naming scheme is followed. Instead of RateLimiter the processor name would be 'LimitRate' and 'LimitRecordRate'.
For each of the dependencies and their transitive dependencies are the licenses compatible with ASF projects? We will need to ensure proper licensing and notice information is provided.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org