You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gopidesupavan (via GitHub)" <gi...@apache.org> on 2024/11/25 15:58:18 UTC
[PR] Fix ruff errors in routes public job [airflow]
gopidesupavan opened a new pull request, #44363:
URL: https://github.com/apache/airflow/pull/44363
https://github.com/apache/airflow/actions/runs/12013016097/job/33486044971?pr=44349#step:8:336
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #44363:
URL: https://github.com/apache/airflow/pull/44363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #44363:
URL: https://github.com/apache/airflow/pull/44363#discussion_r1856882765
##########
airflow/api_fastapi/core_api/routes/public/job.py:
##########
@@ -16,10 +16,11 @@
# under the License.
from __future__ import annotations
+from typing import Annotated
+
from fastapi import Depends, status
from sqlalchemy import select
from sqlalchemy.orm import Session
-from typing_extensions import Annotated
Review Comment:
This is right, it should come from Annotated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #44363:
URL: https://github.com/apache/airflow/pull/44363#discussion_r1856869416
##########
airflow/api_fastapi/core_api/routes/public/job.py:
##########
@@ -16,10 +16,11 @@
# under the License.
from __future__ import annotations
+from typing import Annotated
+
from fastapi import Depends, status
from sqlalchemy import select
from sqlalchemy.orm import Session
-from typing_extensions import Annotated
Review Comment:
Not sure is it use `typing_extensions` or `typing`. pre-commit failing. if it is `typing_extensions` is required may be we have to add ignore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #44363:
URL: https://github.com/apache/airflow/pull/44363#issuecomment-2498456650
> I'm surprised to see that the original build for the PR associated to it was successful. (Ruff didn't complain): https://github.com/apache/airflow/actions/runs/11983768727/job/33477766501?pr=43859
ah might be due to recent upgrade to ruff version :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #44363:
URL: https://github.com/apache/airflow/pull/44363#issuecomment-2498465788
Got it thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #44363:
URL: https://github.com/apache/airflow/pull/44363#issuecomment-2498464085
> > I'm surprised to see that the original build for the PR associated to it was successful. (Ruff didn't complain): https://github.com/apache/airflow/actions/runs/11983768727/job/33477766501?pr=43859
>
> ah might be due to recent upgrade to ruff version :)
https://github.com/apache/airflow/pull/44287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ruff errors in routes public job [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #44363:
URL: https://github.com/apache/airflow/pull/44363#issuecomment-2498448753
I'm surprised to see that the original build for the PR associated to it was successful. (Ruff didn't complain):
https://github.com/apache/airflow/actions/runs/11983768727/job/33477766501?pr=43859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org