You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "vttranlina (via GitHub)" <gi...@apache.org> on 2023/07/31 05:42:40 UTC
[GitHub] [james-project] vttranlina opened a new pull request, #1659: JAMES-3822 Only invoke enqueue delay method when delay input is positive
vttranlina opened a new pull request, #1659:
URL: https://github.com/apache/james-project/pull/1659
- The invoke `SMono(queue.enqueueReactive(mail, delay))` when delay is zero/negative is unnecessary
- `RabbitMQMailQueue.java` does not exist override the delay method, so the invoke to default `enQueue(mail, delay)` makes blocking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on pull request #1659: JAMES-3822 Only invoke enqueue delay method when delay input is positive
Posted by "vttranlina (via GitHub)" <gi...@apache.org>.
vttranlina commented on PR #1659:
URL: https://github.com/apache/james-project/pull/1659#issuecomment-1658096956
> Does it solve our recent perf issues?
yes, This catch comes from the perf issue
> Can you perform a little JMAP perf test and show that it's better now?
## Before
```
> emailQuery: Failed to build request: No attribute named 'inbox 154 (18.85%)
ID' is defined
> jsonPath($.methodResponses[1][1].created).find.exists, found n 100 (12.24%)
othing
> jsonPath($.methodResponses[0][1].list[*]).find.exists, found n 99 (12.12%)
othing
> emailGet: Failed to build request: No attribute named 'emailId 98 (12.00%)
s' is defined
> jsonPath($.methodResponses[0][1].state).find.exists, found not 78 ( 9.55%)
hing
> mailboxChanges: Failed to build request: No attribute named 'm 41 ( 5.02%)
ailboxState' is defined
> jsonPath($.methodResponses[0][1].created).find.exists, found n 28 ( 3.43%)
othing
> jsonPath($.methodResponses[0][1].ids[*]).findAll.exists, found 28 ( 3.43%)
nothing
> emailQuery: Failed to build request: No attribute named 'accou 26 ( 3.18%)
ntId' is defined
> markAsSeen: Failed to build request: No attribute named 'email 24 ( 2.94%)
Ids' is defined
> emailQuery: Failed to build request: No attribute named 'rando 20 ( 2.45%)
mMailbox' is defined
> jsonPath($.methodResponses[0][1].newState).find.exists, found 18 ( 2.20%)
nothing
> emailGet: Failed to build request: No attribute named 'account 16 ( 1.96%)
Id' is defined
> jsonPath($.methodResponses[0][1].list[?(@.role == 'inbox')].id 14 ( 1.71%)
).find.exists, found nothing
> submitEmails: Failed to build request: No attribute named 'dra 13 ( 1.59%)
ftMailboxId' is defined
> getMailboxes: Failed to build request: No attribute named 'acc 11 ( 1.35%)
ountId' is defined
> status.find.is(200), but actually found 500 10 ( 1.22%)
> emailGetState: Failed to build request: No attribute named 'ac 10 ( 1.22%)
countId' is defined
> mailboxChanges: Failed to build request: No attribute named 'a 6 ( 0.73%)
ccountId' is defined
> emailChanges: Failed to build request: No attribute named 'acc 6 ( 0.73%)
ountId' is defined
> markAsFlagged: Failed to build request: No attribute named 'em 4 ( 0.49%)
ailIds' is defined
> markAsAnswered: Failed to build request: No attribute named 'e 4 ( 0.49%)
mailIds' is defined
> markAsSeen: Failed to build request: No attribute named 'accou 3 ( 0.37%)
ntId' is defined
> emailChanges: Failed to build request: No attribute named 'ema 3 ( 0.37%)
ilState' is defined
> submitEmails: Failed to build request: No attribute named 'acc 3 ( 0.37%)
ountId' is defined
```
## After
```
jsonPath($.methodResponses[0][1].list[*]).find.exists, found nothing | 5 | 83.333 %
-- | -- | --
jsonPath($.methodResponses[0][1].created).find.exists, found nothing | 1 | 16.667 %
```
// difference format because "after" got from gatling_html, "before" got from console log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael merged pull request #1659: JAMES-3822 Only invoke enqueue delay method when delay input is positive
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1659:
URL: https://github.com/apache/james-project/pull/1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org