You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/11 11:06:03 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #10037: fix: native annotations broken

villebro opened a new pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037


   ### SUMMARY
   Native annotations are currently broken due to regressions in recent PRs:
   
   ### BEFORE
   Bug number 1: RLS breaks annotations as they only apply to SQL datasources:
   ![image](https://user-images.githubusercontent.com/33317356/84373128-d012af00-abe4-11ea-9322-3c7c7d0823e3.png)
   
   Bug number 2: The `id` of the annotation layer is undefined, hence can't be selected:
   ![captured (1)](https://user-images.githubusercontent.com/33317356/84373096-c4bf8380-abe4-11ea-892d-da5aca120e9d.gif)
   
   ### AFTER
   ![image](https://user-images.githubusercontent.com/33317356/84372600-056acd00-abe4-11ea-8146-468dca8ecf01.png)
   ![captured (2)](https://user-images.githubusercontent.com/33317356/84373635-86769400-abe5-11ea-9279-7e9948ab0c6f.gif)
   
   ### TEST PLAN
   Local testing + new test + CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `1.54%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   67.36%   -1.55%     
   ==========================================
     Files         584      184     -400     
     Lines       31047    18191   -12856     
     Branches     3180        0    -3180     
   ==========================================
   - Hits        21395    12254    -9141     
   + Misses       9543     5937    -3606     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `67.36% <100.00%> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.95% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | | |
   | [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | | |
   | [superset-frontend/src/components/FormRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybVJvdy5qc3g=) | | |
   | ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...d4fb1c8](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `1.80%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   67.11%   -1.81%     
   ==========================================
     Files         584      184     -400     
     Lines       31047    18191   -12856     
     Branches     3180        0    -3180     
   ==========================================
   - Hits        21395    12208    -9187     
   + Misses       9543     5983    -3560     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `67.11% <100.00%> (-0.26%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
   | ... and [408 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...d4fb1c8](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   68.68%   -0.23%     
   ==========================================
     Files         584      584              
     Lines       31047    31056       +9     
     Branches     3180     3180              
   ==========================================
   - Hits        21395    21331      -64     
   - Misses       9543     9610      +67     
   - Partials      109      115       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.06% <ø> (-0.87%)` | :arrow_down: |
   | #javascript | `59.48% <ø> (ø)` | |
   | #python | `67.34% <100.00%> (-0.03%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.95% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...d4fb1c8](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `4.82%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   64.08%   -4.83%     
   ==========================================
     Files         584      584              
     Lines       31047    31056       +9     
     Branches     3180     3180              
   ==========================================
   - Hits        21395    19903    -1492     
   - Misses       9543    10975    +1432     
   - Partials      109      178      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.48% <ø> (ø)` | |
   | #python | `67.34% <100.00%> (-0.03%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.95% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [145 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...d4fb1c8](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   68.89%   -0.02%     
   ==========================================
     Files         584      584              
     Lines       31047    31056       +9     
     Branches     3180     3180              
   ==========================================
   + Hits        21395    21396       +1     
   - Misses       9543     9551       +8     
     Partials      109      109              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.91% <ø> (-0.01%)` | :arrow_down: |
   | #javascript | `59.48% <ø> (ø)` | |
   | #python | `67.34% <100.00%> (-0.03%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.95% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (+<0.01%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...d4fb1c8](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642624894


   I propose merging this as-is, and adding more comprehensive tests later if we refactor annotations (I hadn't worked extensively with the annotation code before, but it seems to be in need of some refactoring at some point).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `4.81%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   64.09%   -4.82%     
   ==========================================
     Files         584      584              
     Lines       31047    31047              
     Branches     3180     3180              
   ==========================================
   - Hits        21395    19901    -1494     
   - Misses       9543    10968    +1425     
   - Partials      109      178      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.48% <ø> (ø)` | |
   | #python | `67.36% <100.00%> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.95% <100.00%> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [142 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...d4fb1c8](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `1.80%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   67.11%   -1.81%     
   ==========================================
     Files         584      184     -400     
     Lines       31047    18191   -12856     
     Branches     3180        0    -3180     
   ==========================================
   - Hits        21395    12208    -9187     
   + Misses       9543     5983    -3560     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `67.11% <100.00%> (-0.26%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
   | ... and [408 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...e391aca](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #10037: fix: native annotations

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#discussion_r438845534



##########
File path: superset/views/annotations.py
##########
@@ -103,7 +103,7 @@ class AnnotationLayerModelView(SupersetModelView):  # pylint: disable=too-many-a
     add_title = _("Add Annotation Layer")
     edit_title = _("Edit Annotation Layer")
 
-    list_columns = ["name", "descr"]
+    list_columns = ["id", "name", "descr"]

Review comment:
       This will make the CRUD view slightly uglier with the `id`, but is necessary based on discussions with @dpgaspar 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `0.25%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   68.65%   -0.26%     
   ==========================================
     Files         584      584              
     Lines       31047    31056       +9     
     Branches     3180     3180              
   ==========================================
   - Hits        21395    21322      -73     
   - Misses       9543     9619      +76     
   - Partials      109      115       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.14% <ø> (-0.79%)` | :arrow_down: |
   | #javascript | `59.48% <ø> (ø)` | |
   | #python | `67.26% <100.00%> (-0.10%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...e391aca](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=h1) Report
   > Merging [#10037](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8744dadca8f98a84c7cbdbd098e53e435627063d&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10037/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10037      +/-   ##
   ==========================================
   - Coverage   68.91%   68.85%   -0.06%     
   ==========================================
     Files         584      584              
     Lines       31047    31056       +9     
     Branches     3180     3180              
   ==========================================
   - Hits        21395    21384      -11     
   - Misses       9543     9563      +20     
     Partials      109      109              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.92% <ø> (ø)` | |
   | #javascript | `59.48% <ø> (ø)` | |
   | #python | `67.26% <100.00%> (-0.10%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.37% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.47% <100.00%> (+0.04%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.80% <100.00%> (-0.15%)` | :arrow_down: |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.43% <100.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.03% <100.00%> (-0.03%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <0.00%> (-0.22%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/10037/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=footer). Last update [8744dad...e391aca](https://codecov.io/gh/apache/incubator-superset/pull/10037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10037: fix: native annotations broken

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10037:
URL: https://github.com/apache/incubator-superset/pull/10037#issuecomment-642576608






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org