[jira] [Comment Edited] (OFBIZ-5741) Convert ProductStore entites CRUD service from simple to entity-auto

["Nicolas Malin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117237#comment-14117237 ] 

Nicolas Malin edited comment on OFBIZ-5741 at 9/1/14 9:28 AM:
--------------------------------------------------------------

Hi Jacques,
I feel all at once small in front of your expert eye.
I check your information for the resource-description and will propose a corrective patch asap.

For the label .. oups, it's a fail. I need improve the permission service like that :
{code}
-                    <fail-property resource="ProductUiLabels" property="ProductCatalogCreatePermissionError"/>
+                    <fail-property resource="ProductUiLabels" property="ProductCatalog${Character.toUpperCase(checkAction.charAt(0)) + checkAction.substring(1).toLowerCase()}PermissionError"/>
{code}
I will review this.

Thx Jacques


was (Author: soledad):
Hi Jacques,
I feel all at once small in front of your expert eye.
I check your information for the resource-description and will propose a corrective patch asap.

For the label .. oups, it's a fail. I need improve the permission service like that :
[code]
-                    <fail-property resource="ProductUiLabels" property="ProductCatalogCreatePermissionError"/>
+                    <fail-property resource="ProductUiLabels" property="ProductCatalog${Character.toUpperCase(checkAction.charAt(0)) + checkAction.substring(1).toLowerCase()}PermissionError"/>
[code]
I will review this.

Thx Jacques

> Convert ProductStore entites CRUD service from simple to entity-auto
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-5741
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5741
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Priority: Trivial
>              Labels: entity-auto, product
>         Attachments: OFBIZ-5741.patch
>
>
> I converted CRUD service to entity-auto for :
>     ProductStoreCatalog
>     ProductStorePaymentSetting
>     ProductStoreEmail
>     ProductStoreVendorPayment
>     ProductStoreShipMeth
>     ProductStoreRole
>     ProductStoreKeywordOvrd
>     ProductStoreSurveyAppl
>     ProductStoreFinActSetting
>     ProductStoreVendorShipment
> I keep to service in mini lang ProductStore.
> I add a new permission service on product store with the same template of produt and productCategory for more homogeneity.
> I run manual test create/update/delete from product store screen with success and I run ./ant clean-all load-demo run-tests without error



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)