You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/28 21:03:18 UTC
[GitHub] [spark] viirya commented on a change in pull request #33339: [SPARK-36133][SQL] Add empty check for catalog name
viirya commented on a change in pull request #33339:
URL: https://github.com/apache/spark/pull/33339#discussion_r697917872
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -799,7 +799,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
intercept[NoSuchDatabaseException] {
- sql(s"ALTER DATABASE `db-not-exist` SET LOCATION '${tmpDir.toURI}'")
+ sql(s"ALTER DATABASE `db_not_exist` SET LOCATION '${tmpDir.toURI}'")
Review comment:
I think you only add a check for catalog, why it affects how the database resolves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org