You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/11 03:45:46 UTC

[GitHub] [incubator-apisix] Miss-you opened a new pull request #1695: [conf] apisix support run as root user

Miss-you opened a new pull request #1695:
URL: https://github.com/apache/incubator-apisix/pull/1695


   NOTE: Please read the Contributing.md guidelines before submitting your patch:
   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   apisix support run as root user
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #1693 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] shenal commented on a change in pull request #1695: [conf] apisix support run as root user

Posted by GitBox <gi...@apache.org>.
shenal commented on a change in pull request #1695:
URL: https://github.com/apache/incubator-apisix/pull/1695#discussion_r446531494



##########
File path: bin/apisix
##########
@@ -86,7 +86,9 @@ local template = require("resty.template")
 local ngx_tpl = [=[
 # Configuration File - Nginx Server Configs
 # This is a read-only file, do not try to modify it.
-
+{% if enable_root then %}
+user root;

Review comment:
       Agree, we should encourage running APISIX with least privilleges not otherwise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1695: [conf] apisix support run as root user

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1695:
URL: https://github.com/apache/incubator-apisix/pull/1695#discussion_r438530416



##########
File path: bin/apisix
##########
@@ -86,7 +86,9 @@ local template = require("resty.template")
 local ngx_tpl = [=[
 # Configuration File - Nginx Server Configs
 # This is a read-only file, do not try to modify it.
-
+{% if enable_root then %}
+user root;

Review comment:
       I do not think that is a good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you closed pull request #1695: [conf] apisix support run as root user

Posted by GitBox <gi...@apache.org>.
Miss-you closed pull request #1695:
URL: https://github.com/apache/incubator-apisix/pull/1695


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org