[jira] Closed: (BEEHIVE-416) DataGrid's setRow feature can lead to skipped rows when going to a previous page

["Nathan Jantz (JIRA)" <be...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/BEEHIVE-416?page=all ]
     
Nathan Jantz closed BEEHIVE-416:
--------------------------------


Verified and closing issue.  Tested based off of Eddie's SVN checkin notes for this bug fix.  For reference and clarification on what solution was implemented, here is his checkin notes:

"The default PagerModel has been rewritten to support dynamically adjusting the row / page given a page size and data set size.  If provided a row "25" with a page size of 10, the current row is set to "20" so that the row "25" appears on the page and the page size is maintained but no rows are skipped."

> DataGrid's setRow feature can lead to skipped rows when going to a previous page
> --------------------------------------------------------------------------------
>
>          Key: BEEHIVE-416
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-416
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: John Rohrlich
>     Assignee: Nathan Jantz
>      Fix For: V1

>
> If the you call setRow(row) on a dataGrid and the row is not the first row of a page you will miss items when going to the previous page. Here is more of an explanation via an example:
> Some data to help explain (I also have a repro if you want it)
> row                   value
> 1                      A
> 2                      B
> 3                      C
> 4                      D
> 5                      E
> 6                      F
> 7                      G
> 8                      H
> Imagine the pageSize is 3 - this means on the first page you'll see rows with the values A B C and on the second page D E F
> case 1 - Now if you set the row to 4 you will see D E F and if you go to the previous page you'll see A B C - good so far
> case 2 - Now set the row to 5 and you will see E F G (labeled page 2) and if you go to the previous page you'll see A B C - rather than B C D as you might expect. Notice that D is skipped in going to the previous page.
> I see two options.
> option 1 - be consistent with the page breaks and let the row fall where it may rather than forcing the "set row" to be the first row of the grid. I would want to be able to highlight this row with a style.
> option 2 - make the "set row" the first row, as it is now, and adjust the page breaks accordingly so that going to the previous page doesn't skip items. This means that the first page may have less than "page size" number of items.
> I favor option 1

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira