You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2016/04/15 04:47:14 UTC

Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46248/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Swapan Shridhar.


Bugs: AMBARI-15904
    https://issues.apache.org/jira/browse/AMBARI-15904


Repository: ambari


Description
-------

YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 7407da3 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py c21bad7 

Diff: https://reviews.apache.org/r/46248/diff/


Testing
-------

Unit tests ran successfully and verified by applying on a running cluster. Image attached to the JIRA.


Thanks,

Sumit Mohanty


Re: Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46248/#review129159
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 62)
<https://reviews.apache.org/r/46248/#comment192624>

    You can use the helper code for getting Hosts on which a given service component is hosted. Should be in as part of AMBARI-15876 (Stack advisor work for adding and disabling LLAP queue when Interactive query is turned on and off respectively.)


- Swapan Shridhar


On April 15, 2016, 2:47 a.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46248/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 2:47 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15904
>     https://issues.apache.org/jira/browse/AMBARI-15904
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 7407da3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py c21bad7 
> 
> Diff: https://reviews.apache.org/r/46248/diff/
> 
> 
> Testing
> -------
> 
> Unit tests ran successfully and verified by applying on a running cluster. Image attached to the JIRA.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Re: Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46248/
-----------------------------------------------------------

(Updated April 16, 2016, 12:57 a.m.)


Review request for Ambari, Jaimin Jetly and Swapan Shridhar.


Bugs: AMBARI-15904
    https://issues.apache.org/jira/browse/AMBARI-15904


Repository: ambari


Description
-------

YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 6680611 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py ccf368f 

Diff: https://reviews.apache.org/r/46248/diff/


Testing
-------

Unit tests ran successfully and verified by applying on a running cluster. Image attached to the JIRA.


Thanks,

Sumit Mohanty


Re: Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46248/#review129161
-----------------------------------------------------------


Ship it!




Fix it and Ship it.

- Swapan Shridhar


On April 15, 2016, 2:47 a.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46248/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 2:47 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15904
>     https://issues.apache.org/jira/browse/AMBARI-15904
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 7407da3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py c21bad7 
> 
> Diff: https://reviews.apache.org/r/46248/diff/
> 
> 
> Testing
> -------
> 
> Unit tests ran successfully and verified by applying on a running cluster. Image attached to the JIRA.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>