You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/05 06:23:49 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #7297: bugfix: Improve support for special characters in schema and table names

codecov-io edited a comment on issue #7297: bugfix: Improve support for special characters in schema and table names
URL: https://github.com/apache/incubator-superset/pull/7297#issuecomment-482962424
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=h1) Report
   > Merging [#7297](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5cf454b4647c6f52b0e7ae49ec5251a46703dd31?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `80.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7297/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7297      +/-   ##
   ==========================================
   + Coverage   65.22%   65.23%   +<.01%     
   ==========================================
     Files         431      431              
     Lines       21147    21154       +7     
     Branches     2343     2343              
   ==========================================
   + Hits        13794    13800       +6     
   - Misses       7237     7238       +1     
     Partials      116      116
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `70.64% <0%> (ø)` | :arrow_up: |
   | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.67% <100%> (ø)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.15% <100%> (+0.04%)` | :arrow_up: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `61.47% <80%> (+0.01%)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.58% <80%> (+0.03%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=footer). Last update [5cf454b...23bdbac](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org