[jira] [Commented] (PHOENIX-5365) IndexToolIT still needs to be improved

["Lars Hofhansl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870656#comment-16870656 ] 

Lars Hofhansl commented on PHOENIX-5365:
----------------------------------------

I tried option I above (adding the tableDDLOptions to the test). That causes them to fail due to invalid combination of table options... Hence I'll avoid calling those tests with options that do not make sense - and hence also speed up the test.

> IndexToolIT still needs to be improved
> --------------------------------------
>
>                 Key: PHOENIX-5365
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5365
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Priority: Major
>
> I looked at it again and found this:
>  * testSaltedVariableLengthPK doesn't use the test options
>  * testSplitIndex also does not use the table options.
> We can either add the table options or more move these test methods out (or not call them).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)