You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/20 02:57:30 UTC

[GitHub] [airflow] kaxil opened a new pull request #9427: Remove redundant functions in airflow/security/utils.py

kaxil opened a new pull request #9427:
URL: https://github.com/apache/airflow/pull/9427


   https://github.com/apache/airflow/pull/8071 removed Auth Backend but didn't remove some functions used by those method.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed pull request #9427: Remove redundant functions in airflow/security/utils.py

Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #9427:
URL: https://github.com/apache/airflow/pull/9427


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #9427: Remove redundant functions in airflow/security/utils.py

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9427:
URL: https://github.com/apache/airflow/pull/9427#discussion_r443113767



##########
File path: airflow/security/utils.py
##########
@@ -56,26 +55,3 @@ def replace_hostname_pattern(components, host=None):
     if not fqdn or fqdn == '0.0.0.0':
         fqdn = get_hostname()
     return '%s/%s@%s' % (components[0], fqdn.lower(), components[2])
-
-
-def get_fqdn(hostname_or_ip=None):

Review comment:
       Shoudln't we deprecate them first? I tthink someone could have used those method - they seem generic enough to be usable.

##########
File path: airflow/security/utils.py
##########
@@ -56,26 +55,3 @@ def replace_hostname_pattern(components, host=None):
     if not fqdn or fqdn == '0.0.0.0':
         fqdn = get_hostname()
     return '%s/%s@%s' % (components[0], fqdn.lower(), components[2])
-
-
-def get_fqdn(hostname_or_ip=None):

Review comment:
       Shoudln't we deprecate them first? I tthink someone could have used those methods - they seem generic enough to be usable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on a change in pull request #9427: Remove redundant functions in airflow/security/utils.py

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #9427:
URL: https://github.com/apache/airflow/pull/9427#discussion_r443201665



##########
File path: airflow/security/utils.py
##########
@@ -56,26 +55,3 @@ def replace_hostname_pattern(components, host=None):
     if not fqdn or fqdn == '0.0.0.0':
         fqdn = get_hostname()
     return '%s/%s@%s' % (components[0], fqdn.lower(), components[2])
-
-
-def get_fqdn(hostname_or_ip=None):

Review comment:
       Agree with @potiuk . It makes more sense to deprecate first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org