You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/07/14 13:41:29 UTC
[1/3] git commit: updated refs/heads/master to a1ff7e2
Repository: cloudstack
Updated Branches:
refs/heads/master 03e8176ba -> a1ff7e24f
coverity 1311707: only sql exception on select would have been caught. passing all runtime exceptions through
Signed-off-by: Daan Hoogland <da...@gmail.com>
This closes #584
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a1ff7e24
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a1ff7e24
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a1ff7e24
Branch: refs/heads/master
Commit: a1ff7e24f334e3e98cb8e6c58b9295b7215d2be7
Parents: 3c125c0
Author: Daan Hoogland <da...@onecht.net>
Authored: Tue Jul 14 10:50:05 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Tue Jul 14 13:41:09 2015 +0200
----------------------------------------------------------------------
framework/db/src/com/cloud/utils/db/SequenceFetcher.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a1ff7e24/framework/db/src/com/cloud/utils/db/SequenceFetcher.java
----------------------------------------------------------------------
diff --git a/framework/db/src/com/cloud/utils/db/SequenceFetcher.java b/framework/db/src/com/cloud/utils/db/SequenceFetcher.java
index fafc8ad..7785d56 100644
--- a/framework/db/src/com/cloud/utils/db/SequenceFetcher.java
+++ b/framework/db/src/com/cloud/utils/db/SequenceFetcher.java
@@ -156,8 +156,6 @@ public class SequenceFetcher {
s_logger.warn("Caught this exception when running: " + (updateStmt != null ? updateStmt.toString() : ""), e);
}
}
- } catch (Exception e) {
- s_logger.warn("Caught this exception when running.", e);
}
return null;
}
[2/3] git commit: updated refs/heads/master to a1ff7e2
Posted by da...@apache.org.
coverity 1311708: sql exception caught instead of generic (runtime)
Signed-off-by: Daan Hoogland <da...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/3c125c0d
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/3c125c0d
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/3c125c0d
Branch: refs/heads/master
Commit: 3c125c0dc10598590694a85ea8d4a3533ba2638c
Parents: e62d952
Author: Daan Hoogland <da...@onecht.net>
Authored: Tue Jul 14 10:45:19 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Tue Jul 14 13:41:09 2015 +0200
----------------------------------------------------------------------
engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/3c125c0d/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
----------------------------------------------------------------------
diff --git a/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java b/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
index 2c68210..db028c4 100644
--- a/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
+++ b/engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
@@ -654,11 +654,8 @@ public class UserVmDaoImpl extends GenericDaoBase<UserVmVO, Long> implements Use
rs.getString("vm_instance.instance_name"), VirtualMachine.Type.valueOf(rs.getString("vm_type"))),
new Pair<Long, String>(rs.getLong("vm_instance.id"), rs.getString("user_vm_details.value"))));
}
- } catch (Exception e) {
- s_logger.error("GetVmsDetailsByNames: Exception: " + e.getMessage());
- throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage());
}
- } catch (Exception e) {
+ } catch (SQLException e) {
s_logger.error("GetVmsDetailsByNames: Exception in sql: " + e.getMessage());
throw new CloudRuntimeException("GetVmsDetailsByNames: Exception: " + e.getMessage());
}
[3/3] git commit: updated refs/heads/master to a1ff7e2
Posted by da...@apache.org.
coverity 1311706: to generic exeption handling on xapi call
Signed-off-by: Daan Hoogland <da...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/e62d9523
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/e62d9523
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/e62d9523
Branch: refs/heads/master
Commit: e62d95237534e856ed7e93615fde47ae3b20aef4
Parents: 03e8176
Author: Daan Hoogland <da...@onecht.net>
Authored: Tue Jul 14 10:41:07 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Tue Jul 14 13:41:09 2015 +0200
----------------------------------------------------------------------
.../xenserver/resource/CitrixResourceBase.java | 12 +++++++++---
.../wrapper/xenbase/CitrixMigrateCommandWrapper.java | 2 +-
2 files changed, 10 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/e62d9523/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
index d8d84a7..05cf0e8 100644
--- a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
+++ b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
@@ -5318,7 +5318,7 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
}
- public boolean AttachConfigDriveToMigratedVm(Connection conn, String vmName, String ipAddr) {
+ public boolean attachConfigDriveToMigratedVm(Connection conn, String vmName, String ipAddr) {
// attach the config drive in destination host
@@ -5375,8 +5375,14 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
return true;
- }catch (Exception ex) {
- s_logger.debug("Failed to attach config drive ISO to the VM "+ vmName + " In host " + ipAddr );
+ } catch (BadServerResponse e) {
+ s_logger.warn("Failed to attach config drive ISO to the VM "+ vmName + " In host " + ipAddr + " due to a bad server response.", e);
+ return false;
+ } catch (XenAPIException e) {
+ s_logger.warn("Failed to attach config drive ISO to the VM "+ vmName + " In host " + ipAddr + " due to a xapi problem.", e);
+ return false;
+ } catch (XmlRpcException e) {
+ s_logger.warn("Failed to attach config drive ISO to the VM "+ vmName + " In host " + ipAddr + " due to a problem in a remote call.", e);
return false;
}
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/e62d9523/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixMigrateCommandWrapper.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixMigrateCommandWrapper.java b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixMigrateCommandWrapper.java
index 00ed622..21930ee 100644
--- a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixMigrateCommandWrapper.java
+++ b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixMigrateCommandWrapper.java
@@ -85,7 +85,7 @@ public final class CitrixMigrateCommandWrapper extends CommandWrapper<MigrateCom
// The iso can be attached to vm only once the vm is (present in the host) migrated.
// Attach the config drive iso device to VM
- if (!citrixResourceBase.AttachConfigDriveToMigratedVm(conn, vmName, dstHostIpAddr)) {
+ if (!citrixResourceBase.attachConfigDriveToMigratedVm(conn, vmName, dstHostIpAddr)) {
s_logger.debug("Config drive ISO attach failed after migration for vm "+vmName);
}