You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/10 13:02:41 UTC
[GitHub] [apisix-ingress-controller] dmsolr opened a new pull request #430: ci: introduce skywalking-eyes
dmsolr opened a new pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430
Please answer these questions before submitting a pull request
Introduce apache/skywalking-eyes to do license header check.
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] heyanlong commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
heyanlong commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r645373562
##########
File path: .github/workflows/license-checker.yml
##########
@@ -14,7 +32,7 @@ jobs:
steps:
- uses: actions/checkout@v2
-
- - name: run license check
- run: |
- make license-check
+ - name: Check License Header
+ uses: apache/skywalking-eyes@v0.1.0
Review comment:
Maybe it is more appropriate to use `apache/skywalking-eyes@main` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] heyanlong commented on pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
heyanlong commented on pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-854469070
Please check if read and write permissions are set
`Settings` -> `Actions` -> `Runners` -> `Workflow permissions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-836674682
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#430](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76afdee) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 36.58% 36.60% +0.01%
==========================================
Files 43 44 +1
Lines 3799 3800 +1
==========================================
+ Hits 1390 1391 +1
Misses 2230 2230
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...76afdee](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-854476751
> Please check if read and write permissions are set
>
> `Settings` -> `Actions` -> `Runners` -> `Workflow permissions`
Thank you, @heyanlong .
The author of skywalking-eyes told me, because of github action limitation, auto-comment bot cannot work while the PR from the fork repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629349330
##########
File path: conf/kubeconfig
##########
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
apiVersion: v1
clusters:
- cluster:
Review comment:
Please double check this file whether we can need a license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-836674682
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#430](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b728a5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 36.58% 36.58%
=======================================
Files 43 43
Lines 3799 3799
=======================================
Hits 1390 1390
Misses 2230 2230
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...7b728a5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r645388528
##########
File path: .github/workflows/license-checker.yml
##########
@@ -14,7 +32,7 @@ jobs:
steps:
- uses: actions/checkout@v2
-
- - name: run license check
- run: |
- make license-check
+ - name: Check License Header
+ uses: apache/skywalking-eyes@v0.1.0
Review comment:
fixed by #510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629849461
##########
File path: conf/kubeconfig
##########
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
apiVersion: v1
clusters:
- cluster:
Review comment:
I am asking the file whether we can add a license header.
If it is not in use, I think it should be removed in a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629791032
##########
File path: conf/kubeconfig
##########
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
apiVersion: v1
clusters:
- cluster:
Review comment:
Actually, this file is not in use, and I'd like to propose that we can remove this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629851392
##########
File path: conf/kubeconfig
##########
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
apiVersion: v1
clusters:
- cluster:
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629791269
##########
File path: .licenserc.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+header:
+ license:
+ spdx-id: Apache-2.0
+ copyright-owner: Apache Software Foundation
+
+ paths-ignore:
+ - 'dist'
+ - 'licenses'
+ - '**/*.md'
+ - '**/testdata/**'
+ - '**/go.mod'
+ - '**/go.sum'
+ - 'LICENSE'
+ - 'NOTICE'
+ - '**/assets/header-templates/**'
+ - '**/assets/lcs-templates/**'
+ - '**/assets/languages.yaml'
+ - '**/assets/assets.gen.go'
+ - '**/*.json'
+ - '.github/ISSUE_TEMPLATE'
+ - '.github/PULL_REQUEST_TEMPLATE'
+ - 'pkg/kube/apisix/client/**'
+ - '**/zz_generated.deepcopy.go'
+
+ comment: on-failure
Review comment:
Please check the editor config, the EOL symbol is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#issuecomment-836674682
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#430](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76afdee) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 36.58% 36.58%
=======================================
Files 43 43
Lines 3799 3799
=======================================
Hits 1390 1390
Misses 2230 2230
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...76afdee](https://codecov.io/gh/apache/apisix-ingress-controller/pull/430?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] dmsolr commented on a change in pull request #430: ci: introduce skywalking-eyes
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #430:
URL: https://github.com/apache/apisix-ingress-controller/pull/430#discussion_r629349330
##########
File path: conf/kubeconfig
##########
@@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
apiVersion: v1
clusters:
- cluster:
Review comment:
Please double check this file whether can we add a license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org