You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/12/16 00:26:03 UTC

Review Request 41403: Removed include tuple from values.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41403/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Removed include tuple from values.cpp.


Diffs
-----

  src/common/values.cpp 3af23f2f9233312ceda27470f44b39e1b4d741c3 
  src/v1/values.cpp fcbf63fc94f776a77f6949fab8365d3f62fb44ef 

Diff: https://reviews.apache.org/r/41403/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 41403: Removed include tuple from values.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41403/#review110620
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41403]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 15, 2015, 11:26 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41403/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed include tuple from values.cpp.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 3af23f2f9233312ceda27470f44b39e1b4d741c3 
>   src/v1/values.cpp fcbf63fc94f776a77f6949fab8365d3f62fb44ef 
> 
> Diff: https://reviews.apache.org/r/41403/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>