You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/24 09:53:57 UTC
[GitHub] [kylin] chenjie-sau opened a new pull request #1462: [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5
chenjie-sau opened a new pull request #1462:
URL: https://github.com/apache/kylin/pull/1462
## Proposed changes
flink upgrade to 1.11.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on pull request #1462: [Kylin-4736] flink upgrade to 1.11.1
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1462:
URL: https://github.com/apache/kylin/pull/1462#issuecomment-716369936
@chenjie-sau @yanghua Thanks！LGTM，works well in my local env (cdh57).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] chenjie-sau commented on pull request #1462: [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5
Posted by GitBox <gi...@apache.org>.
chenjie-sau commented on pull request #1462:
URL: https://github.com/apache/kylin/pull/1462#issuecomment-715891466
@yanghua could you please take a look when free, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] chenjie-sau commented on a change in pull request #1462: KYLIN-4736 flink upgrade to 1.11.1
Posted by GitBox <gi...@apache.org>.
chenjie-sau commented on a change in pull request #1462:
URL: https://github.com/apache/kylin/pull/1462#discussion_r512478705
##########
File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
##########
@@ -64,12 +64,14 @@ public static Configuration getCurrentConfiguration() {
return conf;
}
Configuration conf = hadoopConfig.get();
+ conf.set("fs.hdfs.impl.disable.cache", "true");
Review comment:
This configuration will not affect other functions, it has been verified,This is done in order to prevent the FileSystem from shutting down prematurely, resulting in abnormal file information acquisition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1462: KYLIN-4736 flink upgrade to 1.11.1
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1462:
URL: https://github.com/apache/kylin/pull/1462#discussion_r512462114
##########
File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
##########
@@ -64,12 +64,14 @@ public static Configuration getCurrentConfiguration() {
return conf;
}
Configuration conf = hadoopConfig.get();
+ conf.set("fs.hdfs.impl.disable.cache", "true");
Review comment:
Why it needs to add this parameter here? and will it impact other functions, because there are some place calling this functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] yanghua merged pull request #1462: KYLIN-4736 flink upgrade to 1.11.1
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1462:
URL: https://github.com/apache/kylin/pull/1462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1462: [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1462:
URL: https://github.com/apache/kylin/pull/1462#issuecomment-715894067
## Pull Request Test Coverage Report for [Build 6483](https://coveralls.io/builds/34430039)
* **3** of **4** **(75.0%)** changed or added relevant lines in **2** files are covered.
* **4** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.002%**) to **28.048%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java](https://coveralls.io/builds/34430039/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHadoopUtil.java#L67) | 1 | 2 | 50.0%
<!-- | **Total:** | **3** | **4** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java](https://coveralls.io/builds/34430039/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHadoopUtil.java#L68) | 1 | 16.83% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/34430039/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/34430039/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44) | 2 | 78.95% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/34430039) |
| :-- | --: |
| Change from base [Build 6464](https://coveralls.io/builds/34261216): | -0.002% |
| Covered Lines: | 26253 |
| Relevant Lines: | 93600 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org