You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2015/10/14 02:13:14 UTC

Review Request 39304: Express Upgrade: UX changes for upgrade method selections window

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39304/
-----------------------------------------------------------

Review request for Ambari and Yusaku Sako.


Bugs: AMBARI-13393
    https://issues.apache.org/jira/browse/AMBARI-13393


Repository: ambari


Description
-------

UI for stack upgrade needs to present the user with two different upgrade methods: Rolling Upgrade, Express Upgrade.

Today, the UI invokes the /upgrades API to begin the upgrade. This will need to pass in the type of upgrade as "rolling" or "nonrolling".
The upgrade type will only be available if the stack version contains an upgrade pack for it.

POST api/v1/clusters/c1/upgrades
{
  "Upgrade": {
    "repository_version": "2.3.0.0-2545",
    "type": "NON-ROLLING"
  }
}


Further, the Upgrade Wizard dialog box will need to change the title to reflect if it's a "Rolling Upgrade" or "Express Upgrade".


Diffs
-----

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 880976f 
  ambari-web/app/messages.js b4c32dc 
  ambari-web/app/routes/stack_upgrade_routes.js 9f6034f 
  ambari-web/app/styles/stack_versions.less 4ec60cb 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs f8c4d59 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js 70c6b10 
  ambari-web/app/views/common/modal_popups/cluster_check_popup.js 6e99102 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js b034ac4 

Diff: https://reviews.apache.org/r/39304/diff/


Testing
-------

Tested. All UT passed


Thanks,

Xi Wang

Re: Review Request 39304: Express Upgrade: UX changes for upgrade method selections window

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39304/#review102566
-----------------------------------------------------------



ambari-web/app/messages.js (line 1452)
<https://reviews.apache.org/r/39304/#comment160271>

    Services remains up while the upgrade is performed.  No downtime, but slower.



ambari-web/app/messages.js (line 1454)
<https://reviews.apache.org/r/39304/#comment160273>

    Services are shut down during upgrade.  Incurs downtime, but faster.



ambari-web/app/messages.js (line 1456)
<https://reviews.apache.org/r/39304/#comment160274>

    Pre-Upgrade Checks passed



ambari-web/app/messages.js (line 1457)
<https://reviews.apache.org/r/39304/#comment160275>

    Not allowed by the current version


Please consider the suggested message tweaks.

- Yusaku Sako


On Oct. 14, 2015, 12:13 a.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39304/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 12:13 a.m.)
> 
> 
> Review request for Ambari and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13393
>     https://issues.apache.org/jira/browse/AMBARI-13393
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI for stack upgrade needs to present the user with two different upgrade methods: Rolling Upgrade, Express Upgrade.
> 
> Today, the UI invokes the /upgrades API to begin the upgrade. This will need to pass in the type of upgrade as "rolling" or "nonrolling".
> The upgrade type will only be available if the stack version contains an upgrade pack for it.
> 
> POST api/v1/clusters/c1/upgrades
> {
>   "Upgrade": {
>     "repository_version": "2.3.0.0-2545",
>     "type": "NON-ROLLING"
>   }
> }
> 
> 
> Further, the Upgrade Wizard dialog box will need to change the title to reflect if it's a "Rolling Upgrade" or "Express Upgrade".
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 880976f 
>   ambari-web/app/messages.js b4c32dc 
>   ambari-web/app/routes/stack_upgrade_routes.js 9f6034f 
>   ambari-web/app/styles/stack_versions.less 4ec60cb 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs f8c4d59 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs PRE-CREATION 
>   ambari-web/app/utils/ajax/ajax.js 70c6b10 
>   ambari-web/app/views/common/modal_popups/cluster_check_popup.js 6e99102 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js b034ac4 
> 
> Diff: https://reviews.apache.org/r/39304/diff/
> 
> 
> Testing
> -------
> 
> Tested. All UT passed
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 39304: Express Upgrade: UX changes for upgrade method selections window

Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39304/#review102572
-----------------------------------------------------------

Ship it!


Ship It!

- Richard Zang


On Oct. 14, 2015, 1:11 a.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39304/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 1:11 a.m.)
> 
> 
> Review request for Ambari and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13393
>     https://issues.apache.org/jira/browse/AMBARI-13393
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI for stack upgrade needs to present the user with two different upgrade methods: Rolling Upgrade, Express Upgrade.
> 
> Today, the UI invokes the /upgrades API to begin the upgrade. This will need to pass in the type of upgrade as "rolling" or "nonrolling".
> The upgrade type will only be available if the stack version contains an upgrade pack for it.
> 
> POST api/v1/clusters/c1/upgrades
> {
>   "Upgrade": {
>     "repository_version": "2.3.0.0-2545",
>     "type": "NON-ROLLING"
>   }
> }
> 
> 
> Further, the Upgrade Wizard dialog box will need to change the title to reflect if it's a "Rolling Upgrade" or "Express Upgrade".
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 880976f 
>   ambari-web/app/messages.js b4c32dc 
>   ambari-web/app/routes/stack_upgrade_routes.js 9f6034f 
>   ambari-web/app/styles/stack_versions.less 4ec60cb 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs f8c4d59 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs PRE-CREATION 
>   ambari-web/app/utils/ajax/ajax.js 70c6b10 
>   ambari-web/app/views/common/modal_popups/cluster_check_popup.js 6e99102 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js b034ac4 
> 
> Diff: https://reviews.apache.org/r/39304/diff/
> 
> 
> Testing
> -------
> 
> Tested. All UT passed
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 39304: Express Upgrade: UX changes for upgrade method selections window

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39304/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 6:11 p.m.)


Review request for Ambari and Yusaku Sako.


Changes
-------

Accepted all the messages change.


Bugs: AMBARI-13393
    https://issues.apache.org/jira/browse/AMBARI-13393


Repository: ambari


Description
-------

UI for stack upgrade needs to present the user with two different upgrade methods: Rolling Upgrade, Express Upgrade.

Today, the UI invokes the /upgrades API to begin the upgrade. This will need to pass in the type of upgrade as "rolling" or "nonrolling".
The upgrade type will only be available if the stack version contains an upgrade pack for it.

POST api/v1/clusters/c1/upgrades
{
  "Upgrade": {
    "repository_version": "2.3.0.0-2545",
    "type": "NON-ROLLING"
  }
}


Further, the Upgrade Wizard dialog box will need to change the title to reflect if it's a "Rolling Upgrade" or "Express Upgrade".


Diffs (updated)
-----

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 880976f 
  ambari-web/app/messages.js b4c32dc 
  ambari-web/app/routes/stack_upgrade_routes.js 9f6034f 
  ambari-web/app/styles/stack_versions.less 4ec60cb 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs f8c4d59 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js 70c6b10 
  ambari-web/app/views/common/modal_popups/cluster_check_popup.js 6e99102 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js b034ac4 

Diff: https://reviews.apache.org/r/39304/diff/


Testing
-------

Tested. All UT passed


Thanks,

Xi Wang