[GitHub] [lucene-solr] dsmiley commented on a change in pull request #957: SOLR-13822: Isolated Classloading from packages

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #957: SOLR-13822: Isolated Classloading from packages
URL: https://github.com/apache/lucene-solr/pull/957#discussion_r336840458
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorChain.java
 ##########
 @@ -339,27 +359,20 @@ public UpdateRequestProcessorFactory get() {
       return lazyFactory;
     }
 
-    public class LazyUpdateRequestProcessorFactory extends UpdateRequestProcessorFactory {
-      private final PluginBag.LazyPluginHolder holder;
-      UpdateRequestProcessorFactory delegate;
+    public static class LazyUpdateRequestProcessorFactory extends UpdateRequestProcessorFactory {
+      private final PluginBag.PluginHolder<UpdateRequestProcessorFactory> holder;
 
 Review comment:
   I think it might be nicer if we declared this as simply Supplier<UpdateRequestProcessorFactory> and then made that PluginHolder thing implement a Supplier<T>?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org