You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/29 13:54:40 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3437: [UT] Fix AlterTest UT failed
morningman opened a new pull request #3437:
URL: https://github.com/apache/incubator-doris/pull/3437
Fix: #3432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3437: [UT] Fix AlterTest UT failed
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3437:
URL: https://github.com/apache/incubator-doris/pull/3437#discussion_r417399371
##########
File path: fe/src/test/java/org/apache/doris/alter/AlterTest.java
##########
@@ -135,10 +135,10 @@ public void testConflictAlterOperations() throws Exception {
waitSchemaChangeJobDone(true);
// enable dynamic partition
+ // not adding the `start` property so that it won't drop the origin partition p1, p2 and p3
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3437: [UT] Fix AlterTest UT failed
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3437:
URL: https://github.com/apache/incubator-doris/pull/3437#discussion_r417369939
##########
File path: fe/src/test/java/org/apache/doris/alter/AlterTest.java
##########
@@ -135,10 +135,10 @@ public void testConflictAlterOperations() throws Exception {
waitSchemaChangeJobDone(true);
// enable dynamic partition
+ // not adding the `start` property so that it won't drop the origin partition p1, p2 and p3
Review comment:
Do we need a add another test case to cover the TTL(auto drop out of date partition) feature？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org